github-repos/make
1
0
Fork 0
mirror of https://github.com/mirror/make.git synced 2026-08-19 08:23:28 +08:00
Code Issues Packages Projects Releases Wiki Activity

* src/remake.c (update_goal_chain): [SV 64016] Avoid double negation

Browse Source
This commit is contained in:
Dmitry Goncharov
2023-04-30 09:07:17 -04:00
committed by Paul Smith
parent fec72ea308
commit 5340a3d5d1
1 changed files with 6 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/remake.c
View File

@@ -157,7 +157,7 @@ update_goal_chain (struct goaldep *goaldeps)
{
/* Iterate over all double-colon entries for this file. */
struct file *file, *dchead;
int stop = 0, any_not_updated = 0;
int stop = 0, all_updated = 1;
g = gu->shuf ? gu->shuf : gu;
@@ -253,7 +253,7 @@ update_goal_chain (struct goaldep *goaldeps)
/* Keep track if any double-colon entry is not finished.
When they are all finished, the goal is finished. */
any_not_updated |= !file->updated;
all_updated &= file->updated;
file->dontcare = 0;
@@ -267,7 +267,7 @@ update_goal_chain (struct goaldep *goaldeps)
if (wait)
break;
if (stop || !any_not_updated)
if (stop || all_updated)
{
/* If we have found nothing whatever to do for the goal,
print a message saying nothing needs doing. */
@@ -290,16 +290,13 @@ update_goal_chain (struct goaldep *goaldeps)
else
lastgoal->next = gu->next;
gu = lastgoal == 0 ? goals : lastgoal->next;
if (stop)
break;
}
else
{
lastgoal = gu;
gu = gu->next;
}
lastgoal = gu;
gu = gu->next;
}
/* If we reached the end of the dependency graph update CONSIDERED