From 68b1f216554629ed8df22808cfd9b855e6659ede Mon Sep 17 00:00:00 2001 From: Eduard Kuzmenko Date: Fri, 21 Apr 2017 15:26:45 +0300 Subject: [PATCH 1/2] Update getUserInventoryContents There will be a re-loop if description of the item not the last one in descriptions (and quickDescriptionLookup will rewrite everytime) --- components/users.js | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/components/users.js b/components/users.js index f8cc43a..86bf382 100644 --- a/components/users.js +++ b/components/users.js @@ -441,10 +441,8 @@ SteamCommunity.prototype.getUserInventoryContents = function(userID, appID, cont for (var i = 0; i < descriptions.length; i++) { quickDescriptionLookup[key] = descriptions[i]; - - if (descriptions[i].classid == classID && descriptions[i].instanceid == instanceID) { - return descriptions[i]; - } } + + return quickDescriptionLookup[key]; } }; From a97edfd4929c5d5137c64f284c20970c926bb257 Mon Sep 17 00:00:00 2001 From: Eduard Kuzmenko Date: Fri, 21 Apr 2017 15:46:20 +0300 Subject: [PATCH 2/2] Update users.js --- components/users.js | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/components/users.js b/components/users.js index 86bf382..3881946 100644 --- a/components/users.js +++ b/components/users.js @@ -431,16 +431,14 @@ SteamCommunity.prototype.getUserInventoryContents = function(userID, appID, cont var quickDescriptionLookup = {}; function getDescription(descriptions, classID, instanceID) { - instanceID = instanceID || '0'; // instanceID can be undefined, in which case it's 0. - - var key = classID + '_' + instanceID; + var key = classID + '_' + (instanceID || '0'); // instanceID can be undefined, in which case it's 0. if (quickDescriptionLookup[key]) { return quickDescriptionLookup[key]; } for (var i = 0; i < descriptions.length; i++) { - quickDescriptionLookup[key] = descriptions[i]; + quickDescriptionLookup[descriptions[i].classid + '_' + (descriptions[i].instanceid || '0')] = descriptions[i]; } return quickDescriptionLookup[key];