Add new fuzzer for the FTP listing parsers

* fuzz/Makefile.am: Add wget_ftpls_fuzzer
* fuzz/wget_ftpls_fuzzer.c: New fuzzer
* fuzz/wget_ftpls_fuzzer.dict: Fuzzer dictionary
* fuzz/wget_ftpls_fuzzer.in/starter: Starting corpus
* src/ftp-ls.c: Parsing function take FILE * as argument,
  new function ftp_parse_ls_fp()
* src/ftp.c: Remove static from freefileinfo()
* src/ftp.h: Add ftp_parse_ls_fp() and freefileinfo()

fuzz/Makefile.am

@@ -10,6 +10,7 @@ LDADD = ../lib/libgnu.a \
 
 WGET_TESTS = \
  wget_css_fuzzer$(EXEEXT) \
+ wget_ftpls_fuzzer$(EXEEXT) \
  wget_html_fuzzer$(EXEEXT) \
  wget_options_fuzzer$(EXEEXT)
 
@@ -34,6 +35,9 @@ endif
 wget_css_fuzzer_SOURCES = wget_css_fuzzer.c $(MAIN)
 wget_css_fuzzer_LDADD = ../src/libunittest.a $(LDADD)
 
+wget_ftpls_fuzzer_SOURCES = wget_ftpls_fuzzer.c $(MAIN)
+wget_ftpls_fuzzer_LDADD = ../src/libunittest.a $(LDADD)
+
 wget_html_fuzzer_SOURCES = wget_html_fuzzer.c $(MAIN)
 wget_html_fuzzer_LDADD = ../src/libunittest.a $(LDADD)
 

fuzz/wget_ftpls_fuzzer.c

@@ -0,0 +1,107 @@
+/*
+ * Copyright(c) 2017-2018 Free Software Foundation, Inc.
+ *
+ * This file is part of GNU Wget.
+ *
+ * GNU Wget is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * GNU Wget is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with Wget.  If not, see <https://www.gnu.org/licenses/>.
+ */
+
+#include <config.h>
+
+#include <sys/types.h>
+#include <dirent.h> // opendir, readdir
+#include <stdint.h> // uint8_t
+#include <stdio.h>  // fmemopen
+#include <string.h>  // strncmp
+#include <stdlib.h>  // free
+#include <fcntl.h>  // open flags
+#include <unistd.h>  // close
+#include <setjmp.h> // longjmp, setjmp
+
+#include "wget.h"
+#undef fopen_wgetrc
+
+#ifdef __cplusplus
+  extern "C" {
+#endif
+  #include "ftp.h"
+
+  // declarations for wget internal functions
+  int main_wget(int argc, const char **argv);
+  void cleanup(void);
+  FILE *fopen_wget(const char *pathname, const char *mode);
+  FILE *fopen_wgetrc(const char *pathname, const char *mode);
+  void exit_wget(int status);
+#ifdef __cplusplus
+  }
+#endif
+
+#include "fuzzer.h"
+
+FILE *fopen_wget(const char *pathname, const char *mode)
+{
+	return fopen("/dev/null", mode);
+}
+
+FILE *fopen_wgetrc(const char *pathname, const char *mode)
+{
+	return NULL;
+}
+
+#ifdef FUZZING
+void exit_wget(int status)
+{
+}
+#else
+void exit(int status)
+{
+}
+#endif
+
+int LLVMFuzzerTestOneInput(const uint8_t *data, size_t size)
+{
+	FILE *fp, *bak;
+	struct fileinfo *fi;
+
+	if (size > 4096) // same as max_len = ... in .options file
+		return 0;
+
+	bak = stderr;
+	stderr = fopen("/dev/null", "w");
+
+	fp = fmemopen((void *) data, size, "r");
+	if (!fp) return 0;
+
+	fi = ftp_parse_ls_fp(fp, ST_UNIX);
+	freefileinfo(fi);
+	rewind(fp);
+
+	fi = ftp_parse_ls_fp(fp, ST_VMS);
+	freefileinfo(fi);
+	rewind(fp);
+
+	fi = ftp_parse_ls_fp(fp, ST_WINNT);
+	freefileinfo(fi);
+	rewind(fp);
+
+	fi = ftp_parse_ls_fp(fp, ST_MACOS);
+	freefileinfo(fi);
+
+	fclose(fp);
+
+	fclose(stderr);
+	stderr = bak;
+
+	return 0;
+}

fuzz/wget_ftpls_fuzzer.dict

@@ -0,0 +1,20 @@
+"Jan"
+"Feb"
+"Mar"
+"Apr"
+"May"
+"Jun"
+"Jul"
+"Aug"
+"Sep"
+"Oct"
+"Nov"
+"Dec"
+"total"
+"0644"
+"0755"
+" -> "
+".."
+"Total of "
+".DIR"
+".DIR;1"

fuzz/wget_ftpls_fuzzer.in/starter

@@ -0,0 +1 @@
+-rwxr--r--  1   owner   group 640   1970 01 01  test