From 57144518d084dff4ecf792e2d7c38038e52a72f4 Mon Sep 17 00:00:00 2001 From: Teon Banek Date: Mon, 9 Oct 2017 16:02:21 +0200 Subject: [PATCH] Remove rechecking external projects Summary: This is probably a bug in CMake. When the external projects are forced to be rechecked, CPack takes their outputs and puts them in binary release. Since rechecking is removed, this means that any changes to external projects (like gflags or glog) will not be recompiled with plain `make all`. You need to call `make clean` first. The same applies to catching configuration like removal of filenames in glog when creating a release build. Reviewers: mferencevic Reviewed By: mferencevic Subscribers: pullbot Differential Revision: https://phabricator.memgraph.io/D890 --- libs/CMakeLists.txt | 6 ------ 1 file changed, 6 deletions(-) diff --git a/libs/CMakeLists.txt b/libs/CMakeLists.txt index 892903d6b..ebf19e136 100644 --- a/libs/CMakeLists.txt +++ b/libs/CMakeLists.txt @@ -56,12 +56,6 @@ function(add_external_project name) -DCMAKE_INSTALL_PREFIX=${source_dir} ${KW_CMAKE_ARGS} INSTALL_COMMAND ${KW_INSTALL_COMMAND}) - # Force the build step (which will check if the source changed) by removing - # the stamped build file. - ExternalProject_Add_Step( - ${name}-proj force-build - COMMAND ${CMAKE_COMMAND} -E remove ${CMAKE_CURRENT_BINARY_DIR}/src/${name}-proj-stamp/${name}-proj-build - DEPENDERS configure ALWAYS 1) endfunction(add_external_project) # Calls `add_external_project`, sets NAME_LIBRARY, NAME_INCLUDE_DIR variables