document/eng-practices
2
0
Fork 0
mirror of https://github.com/eng-practices/eng-practices.git synced 2026-08-13 22:23:28 +08:00
Code Issues Packages Projects Releases Wiki Activity

Internal change

Browse Source 
PiperOrigin-RevId: 281192419
This commit is contained in:
A. Googler
2019-11-18 17:37:57 -08:00
committed by Copybara-Service
parent edbebffb0b
commit 74ca7664bf
1 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
review/developer/cl-descriptions.md
View File

@@ -41,6 +41,11 @@ approach. If there are any shortcomings to the approach, they should be
mentioned. If relevant, include background information such as bug numbers,
benchmark results, and links to design documents.
If you include links to external resources consider that they may not be visible
to future readers due to access restrictions of retention policies. Where
possible include enough context for reviewers and future readers to understand
the CL.
Even small CLs deserve a little attention to detail. Put the CL in context.
## Bad CL Descriptions {#bad}