3.19.10

https://dev.doctormckay.com/topic/383-error-in-node-steamcommunity/

components/chat.js

@@ -42,9 +42,17 @@ SteamCommunity.prototype.chatLogon = function(interval, uiMode) {
 	var self = this;
 	this.getWebApiOauthToken(function(err, token) {
 		if(err) {
+			var fatal = err.message.indexOf('not authorized') != -1;
+
+			if (!fatal) {
+				self.chatState = SteamCommunity.ChatState.LogOnFailed;
+				setTimeout(self.chatLogon.bind(self), 5000);
+			} else {
+				self.chatState = SteamCommunity.ChatState.Offline;
+			}
+
+			self.emit('chatLogOnFailed', err, fatal);
 			self.emit('debug', "Cannot get oauth token: " + err.message);
-			self.chatState = SteamCommunity.ChatState.LogOnFailed;
-			setTimeout(self.chatLogon.bind(self), 5000);
 			return;
 		}
 		
@@ -57,15 +65,17 @@ SteamCommunity.prototype.chatLogon = function(interval, uiMode) {
 			"json": true
 		}, function(err, response, body) {
 			if(err || response.statusCode != 200) {
-				self.emit('debug', 'Error logging into webchat: ' + (err ? err.message : "HTTP error " + response.statusCode));
 				self.chatState = SteamCommunity.ChatState.LogOnFailed;
+				self.emit('chatLogOnFailed', err ? err : new Error("HTTP error " + response.statusCode), false);
+				self.emit('debug', 'Error logging into webchat: ' + (err ? err.message : "HTTP error " + response.statusCode));
 				setTimeout(self.chatLogon.bind(self), 5000);
 				return;
 			}
 			
 			if(body.error != 'OK') {
-				self.emit('debug', 'Error logging into webchat: ' + body.error);
 				self.chatState = SteamCommunity.ChatState.LogOnFailed;
+				self.emit('chatLogOnFailed', new Error(body.error), false);
+				self.emit('debug', 'Error logging into webchat: ' + body.error);
 				setTimeout(self.chatLogon.bind(self), 5000);
 				return;
 			}
@@ -181,8 +191,8 @@ SteamCommunity.prototype._chatPoll = function() {
 			return;
 		}
 		
-		if(body.error != 'OK') {
-			self.emit('debug', 'Error in chat poll: ' + body.error);
+		if(!body || body.error != 'OK') {
+			self.emit('debug', 'Error in chat poll: ' + (body && body.error ? body.error : "Malformed response"));
 			return;
 		}
 		

components/http.js

@@ -130,7 +130,7 @@ SteamCommunity.prototype._checkTradeError = function(html, callback) {
 	var match = html.match(/<div id="error_msg">\s*([^<]+)\s*<\/div>/);
 	if (match) {
 		var err = new Error(match[1].trim());
-		callback(new Error(err));
+		callback(err);
 		return err;
 	}
 

components/profile.js

@@ -114,6 +114,10 @@ SteamCommunity.prototype.editProfile = function(settings, callback) {
 		}
 		
 		self._myProfile("edit", values, function(err, response, body) {
+			if (settings.customURL) {
+				delete self._profileURL;
+			}
+
 			if(err || response.statusCode != 200) {
 				if(callback) {
 					callback(err || new Error("HTTP error " + response.statusCode));

components/twofactor.js

@@ -61,7 +61,15 @@ SteamCommunity.prototype.finalizeTwoFactor = function(secret, activationCode, ca
 			return;
 		}
 
-		finalize(token);
+		SteamTotp.getTimeOffset(function(err, offset, latency) {
+			if (err) {
+				callback(err);
+				return;
+			}
+
+			diff = offset;
+			finalize(token);
+		});
 	});
 
 	function finalize(token) {

examples/disable_twofactor.js

@@ -0,0 +1,61 @@
+var SteamCommunity = require('../index.js');
+var ReadLine = require('readline');
+var fs = require('fs');
+
+var community = new SteamCommunity();
+var rl = ReadLine.createInterface({
+	"input": process.stdin,
+	"output": process.stdout
+});
+
+rl.question("Username: ", function(accountName) {
+	rl.question("Password: ", function(password) {
+		rl.question("Two-Factor Auth Code: ", function(authCode) {
+			rl.question("Revocation Code: R", function(rCode) {
+				doLogin(accountName, password, authCode, "", rCode);
+			});
+		});
+	});
+});
+
+function doLogin(accountName, password, authCode, captcha, rCode) {
+	community.login({
+		"accountName": accountName,
+		"password": password,
+		"twoFactorCode": authCode,
+		"captcha": captcha
+	}, function(err, sessionID, cookies, steamguard) {
+		if(err) {
+			if(err.message == 'SteamGuard') {
+				console.log("This account does not have two-factor authentication enabled.");
+				process.exit();
+				return;
+			}
+
+			if(err.message == 'CAPTCHA') {
+				console.log(err.captchaurl);
+				rl.question("CAPTCHA: ", function(captchaInput) {
+					doLogin(accountName, password, authCode, captchaInput);
+				});
+
+				return;
+			}
+
+			console.log(err);
+			process.exit();
+			return;
+		}
+
+		console.log("Logged on!");
+		community.disableTwoFactor("R" + rCode, function(err) {
+			if(err) {
+				console.log(err);
+				process.exit();
+				return;
+			}
+
+			console.log("Two-factor authentication disabled!");
+			process.exit();
+		});
+	});
+}

index.js

@@ -135,6 +135,8 @@ SteamCommunity.prototype.login = function(details, callback) {
 				callback(error);
 			} else if(!body.success) {
 				callback(new Error(body.message || "Unknown error"));
+			} else if(!body.oauth) {
+				callback(new Error("Malformed response"));
 			} else {
 				var sessionID = generateSessionID();
 				var oAuth = JSON.parse( body.oauth );
@@ -339,20 +341,34 @@ SteamCommunity.prototype.loggedIn = function(callback) {
 
 SteamCommunity.prototype._myProfile = function(endpoint, form, callback) {
 	var self = this;
-	this.httpRequest("https://steamcommunity.com/my", {"followRedirect": false}, function(err, response, body) {
-		if(err || response.statusCode != 302) {
-			callback(err || "HTTP error " + response.statusCode);
-			return;
-		}
-		
-		var match = response.headers.location.match(/steamcommunity\.com(\/(id|profiles)\/[^\/]+)\/?/);
-		if(!match) {
-			callback(new Error("Can't get profile URL"));
-			return;
-		}
 
+	if (this._profileURL) {
+		completeRequest(this._profileURL);
+	} else {
+		this.httpRequest("https://steamcommunity.com/my", {"followRedirect": false}, function(err, response, body) {
+			if(err || response.statusCode != 302) {
+				callback(err || "HTTP error " + response.statusCode);
+				return;
+			}
+
+			var match = response.headers.location.match(/steamcommunity\.com(\/(id|profiles)\/[^\/]+)\/?/);
+			if(!match) {
+				callback(new Error("Can't get profile URL"));
+				return;
+			}
+
+			self._profileURL = match[1];
+			setTimeout(function () {
+				delete self._profileURL; // delete the cache
+			}, 60000);
+
+			completeRequest(match[1]);
+		}, "steamcommunity");
+	}
+
+	function completeRequest(url) {
 		var options = {
-			"uri": "https://steamcommunity.com" + match[1] + "/" + endpoint,
+			"uri": "https://steamcommunity.com" + url + "/" + endpoint,
 			"method": "GET"
 		};
 
@@ -362,10 +378,9 @@ SteamCommunity.prototype._myProfile = function(endpoint, form, callback) {
 		}
 
 		self.httpRequest(options, callback, "steamcommunity");
-	}, "steamcommunity");
+	}
 };
 
-
 require('./components/http.js');
 require('./components/chat.js');
 require('./components/profile.js');

package.json

@@ -1,6 +1,6 @@
 {
 	"name": "steamcommunity",
-	"version": "3.19.5",
+	"version": "3.19.10",
 	"description": "Provides an interface for logging into and interacting with the Steam Community website",
 	"keywords": ["steam", "steam community"],
 	"homepage": "https://github.com/DoctorMcKay/node-steamcommunity",