tursom/memgraph
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix cost estimator test

Browse Source
This commit is contained in:
Josip Mrden
2023-06-23 14:47:41 +02:00
parent 80a0d12e08
commit edd902cd18
2 changed files with 3 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/query/plan/cost_estimator.hpp
View File

@@ -302,13 +302,9 @@ class CostEstimator : public HierarchicalLogicalOperatorVisitor {
// Estimate cost on the subquery branch independently, use a copy
auto last_scope = scopes_.back();
double subquery_cost = EstimateCostOnBranch(&op.subquery_, last_scope);
subquery_cost = subquery_cost != 0 ? subquery_cost : 1;
cardinality_ *= subquery_cost;
// if the query is a unit subquery, we don't want the cost to be zero but 1xN
double input_cost = cost();
input_cost = input_cost == 0 ? 1 : input_cost;
subquery_cost = subquery_cost == 0 ? 1 : subquery_cost;
cardinality_ *= input_cost * subquery_cost;
IncrementCost(CostParam::kSubquery);
return false;

2
tests/unit/query_cost_estimator.cpp
View File

@@ -201,7 +201,7 @@ TEST_F(QueryCostEstimator, SubqueryCartesian) {
std::shared_ptr<LogicalOperator> input = std::make_shared<ScanAll>(std::make_shared<Once>(), NextSymbol());
std::shared_ptr<LogicalOperator> subquery = std::make_shared<ScanAll>(std::make_shared<Once>(), NextSymbol());
MakeOp<memgraph::query::plan::Apply>(input, subquery, true);
EXPECT_COST(CostParam::kSubquery * no_vertices * no_vertices);
EXPECT_COST(CostParam::kSubquery * no_vertices * no_vertices + no_vertices);
}
TEST_F(QueryCostEstimator, UnitSubquery) {