Marko Budiselić
2f81d4d092
Merge branch 'project-pineapples' into add-gnuplot-example
2023-03-01 23:41:21 +01:00
János Benjamin Antal
27d99b620d
Merge pull request #761 from memgraph/MG-access-control-benchmark-fixes
...
[🍍 < MG] Fix mgbench access control benchmark
2023-02-17 17:33:58 +01:00
János Benjamin Antal
a2ce9c4396
Trigger CI
2023-02-15 13:59:31 +01:00
János Benjamin Antal
3b0d531343
Supress clang-tidy warning
2023-02-15 09:07:48 +01:00
János Benjamin Antal
a17010ed16
Supress clang-tidy warnings
2023-02-15 08:37:45 +01:00
János Benjamin Antal
74f53369c0
Add two more queries to simple benchmark
2023-02-09 13:17:55 +01:00
János Benjamin Antal
2b3141879b
Make the output table nicer for comparing results
2023-02-09 13:17:46 +01:00
János Benjamin Antal
53f95ed1a7
Format python file
2023-02-09 13:17:15 +01:00
János Benjamin Antal
b678e6a63b
Handle bool flags properly in benchmark runner
2023-02-09 12:42:02 +01:00
János Benjamin Antal
563035645c
Add command line flag to opt for using MultiFrame
2023-02-09 12:41:41 +01:00
János Benjamin Antal
12bc78ca2d
Add command line flag to determine MultiFrame size
2023-02-09 12:41:17 +01:00
János Benjamin Antal
a9a388ce44
Use parametrized queries for vertex creation
2023-02-08 13:52:51 +01:00
János Benjamin Antal
6bc2e6d8b6
Merge remote-tracking branch 'origin/project-pineapples' into MG-access-control-benchmark-fixes
2023-02-08 13:48:50 +01:00
János Benjamin Antal
a02abc8f79
Merge pull request #763 from memgraph/T1235-MG-implement-EdgeUniquenessFilter-with-PullMultiple
...
Implement edge uniqueness filter with pull multiple
2023-02-08 13:40:15 +01:00
gvolfing
096d1ce5f4
Invert boolean logic when checking for unique edges
2023-02-08 12:57:21 +01:00
gvolfing
657279949a
Fix compile error
2023-02-08 12:13:46 +01:00
gvolfing
25226cca92
Update src/query/v2/plan/operator.cpp
...
Co-authored-by: Jure Bajic <jure.bajic@memgraph.com >
2023-02-08 11:41:43 +01:00
János Benjamin Antal
292a55f4ff
Add new line at the end of dataset file
2023-02-08 11:28:19 +01:00
gvolfing
37f19867b0
Make EdgeUniquenessFilterCursor impl simpler
2023-02-07 08:25:50 +01:00
János Benjamin Antal
b26c7d09ef
Ignore not value equality property filters for ScanByPrimaryKey
2023-02-06 16:39:42 +01:00
János Benjamin Antal
4bad8c0d1e
Filter edges on types
2023-02-06 16:14:39 +01:00
János Benjamin Antal
2b01f2280c
Add TODO about failing query
2023-02-06 16:14:21 +01:00
gvolfing
ac59e7f7e0
Move loop variables incrementation into the same place
2023-02-06 15:54:07 +01:00
gvolfing
7e99f32adb
Remove uncommented, useless code
2023-02-06 15:47:18 +01:00
gvolfing
a1a612899c
Merge branch 'project-pineapples' into T1235-MG-implement-EdgeUniquenessFilter-with-PullMultiple
2023-02-06 13:53:51 +01:00
gvolfing
2219dee6f6
Add initial impl for EdgeUniquenessFilterCursor::PullMultiple
2023-02-06 12:49:32 +01:00
János Benjamin Antal
7bf8550c86
Merge remote-tracking branch 'origin/project-pineapples' into MG-access-control-benchmark-fixes
2023-02-06 08:18:25 +01:00
János Benjamin Antal
8b392ecc97
Merge pull request #752 from memgraph/T1226-MG-Implement-scanbyprimarykey-with-multiframe
...
Implement ScanByPrimaryKey with multiframe
2023-02-06 08:13:43 +01:00
gvolfing
8e315875f2
Update src/query/v2/plan/operator.cpp
...
Co-authored-by: János Benjamin Antal <antaljanosbenjamin@users.noreply.github.com >
2023-02-02 07:44:47 +01:00
János Benjamin Antal
41183b328b
Invalidate consumed frames in ScanByPrimaryKey
2023-02-01 17:19:02 +01:00
János Benjamin Antal
c9a0c15c16
Make frames invalid on consumption
2023-02-01 16:17:06 +01:00
János Benjamin Antal
50327254e0
Make queries into a single line
2023-02-01 14:59:50 +01:00
János Benjamin Antal
24ae6069f0
Split edge creation into batches
2023-02-01 14:31:56 +01:00
János Benjamin Antal
7be66f0c54
Add unwind based dataset creator
2023-02-01 14:24:04 +01:00
János Benjamin Antal
b136cd71d2
Fix DistributedCreatedNodeCursor in case of UNWIND
2023-02-01 14:22:47 +01:00
János Benjamin Antal
a38401130e
Set vertex id in Expand properly
2023-02-01 13:24:58 +01:00
gvolfing
bf93b53e7d
Fix compile error due to wrong aggregate field name
2023-02-01 12:36:27 +01:00
gvolfing
4be4a86d0a
Apply suggestions from code review
...
Co-authored-by: János Benjamin Antal <antaljanosbenjamin@users.noreply.github.com >
2023-02-01 11:39:48 +01:00
János Benjamin Antal
9a805bff8b
Merge remote-tracking branch 'origin/T1226-MG-Implement-scanbyprimarykey-with-multiframe' into MG-create-properties
2023-02-01 11:37:06 +01:00
gvolfing
7d63236f87
Set the default pull-mechanism back to single-pull
2023-01-31 17:36:52 +01:00
gvolfing
4f8c241934
Merge branch 'project-pineapples' into T1226-MG-Implement-scanbyprimarykey-with-multiframe
2023-01-31 17:33:12 +01:00
gvolfing
60b71cc2c1
Rework ScanByPrimaryKey operator - multiframe
2023-01-31 17:30:31 +01:00
János Benjamin Antal
da28a29c7f
Pass properties when creating vertices
2023-01-31 17:09:41 +01:00
János Benjamin Antal
303362d41c
Merge pull request #751 from memgraph/T1229-MG-implement-unwind-with-multiframe
...
Add implementation of `UNWIND` with `MultiFrame`
2023-01-31 15:06:46 +01:00
gvolfing
272e710510
Merge branch 'T1229-MG-implement-unwind-with-multiframe' into T1226-MG-Implement-scanbyprimarykey-with-multiframe
2023-01-31 08:58:27 +01:00
gvolfing
0e3229756f
Merge branch 'project-pineapples' into T1226-MG-Implement-scanbyprimarykey-with-multiframe
2023-01-31 08:49:22 +01:00
János Benjamin Antal
e96eed81b1
Merge branch 'project-pineapples' into T1229-MG-implement-unwind-with-multiframe
2023-01-30 15:56:44 +01:00
János Benjamin Antal
7fa7586940
Merge pull request #729 from memgraph/T1216-MG-implement-aggregate
...
Implement Aggregate with `MultiFrame`
2023-01-30 15:56:30 +01:00
gvolfing
436e41f71f
Init POC of ScanByPrimaryKey multiframe
2023-01-30 13:06:05 +01:00
János Benjamin Antal
fd047e7303
Unify even more logic
2023-01-27 17:10:21 +01:00
János Benjamin Antal
9214c715e2
Address review comment
2023-01-27 17:05:03 +01:00
János Benjamin Antal
44fc2d01c7
Unify logic between multi and single frame pull
2023-01-27 17:04:40 +01:00
János Benjamin Antal
d36c0cc424
Refactor AggregateCursor::ProcessAll
2023-01-27 16:52:46 +01:00
János Benjamin Antal
2ecf580ae7
Eliminate warnings
2023-01-27 16:50:58 +01:00
János Benjamin Antal
c12a5a9019
Make multi-create queries work
2023-01-27 16:50:16 +01:00
János Benjamin Antal
883922dba5
Eliminate warning about deprecated macro
2023-01-27 13:11:55 +01:00
János Benjamin Antal
c7591887a8
Merge branch 'project-pineapples' into T1216-MG-implement-aggregate
2023-01-27 09:07:14 +01:00
János Benjamin Antal
33454c7d8e
Add implementation
2023-01-27 08:43:10 +01:00
János Benjamin Antal
f67422f8b9
Merge pull request #742 from memgraph/T1223-MG-implement-filter-with-multiframe
...
Make access control benchmark run with `MultiFrame`
2023-01-26 21:19:36 +01:00
János Benjamin Antal
23297c2afb
Remove unnecessary function
2023-01-26 19:47:56 +01:00
János Benjamin Antal
3d35a10783
Merge branch 'project-pineapples' into T1223-MG-implement-filter-with-multiframe
2023-01-26 17:31:19 +01:00
János Benjamin Antal
999015a250
Merge pull request #738 from memgraph/T1214-MG-implement-expand-with-multiframe
...
Implement expand with `MultiFrame`
2023-01-26 17:30:55 +01:00
János Benjamin Antal
7d3d52c067
Merge branch 'project-pineapples' into T1214-MG-implement-expand-with-multiframe
2023-01-25 16:19:56 +01:00
János Benjamin Antal
6d4401dc92
Merge pull request #707 from memgraph/T1165-MG-add-property-based-high-level-query-test
...
Add property based high level query tests
2023-01-25 16:19:22 +01:00
János Benjamin Antal
0d00ae74dd
Merge branch 'project-pineapples' into T1214-MG-implement-expand-with-multiframe
2023-01-25 15:27:19 +01:00
János Benjamin Antal
16b78e4eb3
Merge branch 'project-pineapples' into T1165-MG-add-property-based-high-level-query-test
2023-01-25 15:14:26 +01:00
János Benjamin Antal
d44910bc9a
Merge pull request #710 from memgraph/T1190-MG-Implement-ScanAll-and-ScanAllByLabel-with-MultiFrame_2
...
Implement scan all and scan all by label with `MultiFrame`
2023-01-25 15:09:11 +01:00
gvolfing
54c1efab7f
Merge branch 'project-pineapples' into 'T1165-MG-add-property-based-high-level-query-test'
2023-01-25 13:40:16 +01:00
János Benjamin Antal
7a0c9beba5
Merge branch 'project-pineapples' into T1190-MG-Implement-ScanAll-and-ScanAllByLabel-with-MultiFrame_2
2023-01-25 13:17:28 +01:00
János Benjamin Antal
e13faf41e9
Merge pull request #663 from memgraph/T1167-MG-create-scanbyprimarykey-operator
...
Create ScanAllByPrimaryKey operator
2023-01-25 12:51:04 +01:00
gvolfing
e24a6a86e4
Apply changes from code-review
2023-01-25 12:42:44 +01:00
gvolfing
3bc9c571a0
Make the use RequestRouter more restricted
2023-01-25 07:02:03 +01:00
János Benjamin Antal
7972b3af43
Merge branch 'T1214-MG-implement-expand-with-multiframe' into T1223-MG-implement-filter-with-multiframe
2023-01-24 17:25:30 +01:00
János Benjamin Antal
e2a1029120
Fix simulation test
2023-01-24 17:24:10 +01:00
János Benjamin Antal
7cb07672ff
Make DistributedExpandCursor handle existing nodes with MultiFrame
2023-01-24 17:17:47 +01:00
gvolfing
36fccc32c2
Address PR comments
2023-01-24 16:59:38 +01:00
János Benjamin Antal
4908af5a18
Make DistributedExpand operator handle repeated vertices
2023-01-24 16:33:15 +01:00
János Benjamin Antal
fa8eee2043
Use destination vertex as other end for out edges
2023-01-24 16:19:24 +01:00
gvolfing
b4ae8aea95
Apply suggestions from code review
2023-01-24 15:59:50 +01:00
gvolfing
27ff18733c
NOLINTNEXTLINE(cppcoreguidelines-macro-usage)
2023-01-23 15:08:51 +01:00
gvolfing
0aa7daf002
NOLINTNEXTLINE(bugprone-macro-parentheses)
2023-01-23 14:34:16 +01:00
gvolfing
b341a8d7dd
Merge branch 'project-pineapples' into T1165-MG-add-property-based-high-level-query-test
2023-01-23 14:12:42 +01:00
gvolfing
b7dbc7267b
Appease clang-tidy bugprone-macro-parentheses
2023-01-23 14:09:25 +01:00
gvolfing
1951d781d0
Appease clang-tidy
2023-01-23 13:43:51 +01:00
gvolfing
e65f585fc6
Appease clang-tidy
2023-01-23 13:22:27 +01:00
gvolfing
fa86d4c989
Offer sacrifice to the lisp gods
2023-01-23 12:51:00 +01:00
gvolfing
fcbacdc80d
Rename ScanAllByPrimaryKey operator, fix e2e fail
...
Rename ScanAllByPrimaryKey operator to ScanByPrimaryKey. Make the
LabelIndexExist function use the same functionality as PrimaryKeyExists
again, for now. Previously it was just returning false and before that
it used the same implementation as PrimaryKeyExist. The change to false
broke some existing e2e tests that relied on some label based indexing
operator being instantiated.
2023-01-23 11:56:58 +01:00
gvolfing
69fa4e8c8d
Return fals from unimplemented function, so the benchmark tests can run
2023-01-23 10:43:41 +01:00
gvolfing
ea646e1803
Add missing mock implementation to MockedRequestRouter
2023-01-23 10:06:52 +01:00
gvolfing
89d26c36c9
Merge branch 'project-pineapples' into T1167-MG-create-scanbyprimarykey-operator
2023-01-23 08:42:14 +01:00
gvolfing
cf76e0e19b
React to PR comments
2023-01-23 08:27:44 +01:00
János Benjamin Antal
900ece8109
Add PullMultiple to DeleteCursor
2023-01-20 23:04:52 +01:00
János Benjamin Antal
544c75c212
Add explanation about limitations of current implementation
2023-01-20 23:04:33 +01:00
János Benjamin Antal
0285b56915
Fix compilation error
2023-01-20 23:01:23 +01:00
János Benjamin Antal
515a52130e
Prevent moving from valid frames during defregmentation of MultiFrame
2023-01-20 22:12:24 +01:00
János Benjamin Antal
55b5d76092
Add docs to PullMultiple
2023-01-20 21:38:51 +01:00
János Benjamin Antal
0eee3ad7b7
Fix DistributedExpandCursor
2023-01-20 21:38:35 +01:00
János Benjamin Antal
c9299a6c72
Turn the scan all cursor into an automaton
2023-01-20 21:37:57 +01:00
János Benjamin Antal
de99025c39
Implement PullMultiple for FilterCursor
2023-01-20 15:36:38 +01:00
János Benjamin Antal
be39fac72e
Add return value to PullMultiple
...
Because the `FilterCursor` might push down the same multiframe multiple
times, it is easier if each cursor maintains whether it put any new data
on the `MultiFrame` or not. This way each cursor can decide easily
whether it has to do more work or not.
2023-01-20 15:36:24 +01:00
gvolfing
5eea3ceee4
Apply suggestions from code review
...
Co-authored-by: Jure Bajic <jure.bajic@memgraph.com >
Co-authored-by: János Benjamin Antal <antaljanosbenjamin@users.noreply.github.com >
2023-01-20 06:22:37 +01:00
gvolfing
cc643aac69
Deal with unprotected comma in MOCKED_METHOD
2023-01-19 17:45:15 +01:00
János Benjamin Antal
e7f10ec8f4
Remove duplicated definition
2023-01-19 17:44:03 +01:00
gvolfing
6fe244b209
Add missing MOCK_METHODS to MockedRequestRouter
2023-01-19 17:16:29 +01:00
János Benjamin Antal
ede6281e00
Fix unit tests
2023-01-19 16:58:11 +01:00
János Benjamin Antal
70c8ed9180
Merge branch 'T1190-MG-Implement-ScanAll-and-ScanAllByLabel-with-MultiFrame_2' into T1214-MG-implement-expand-with-multiframe
2023-01-19 16:56:23 +01:00
János Benjamin Antal
59b39e03cb
Merge remote-tracking branch 'origin/project-pineapples' into T1190-MG-Implement-ScanAll-and-ScanAllByLabel-with-MultiFrame_2
2023-01-19 16:24:13 +01:00
gvolfing
96ea113a69
Merge branch 'project-pineapples' into T1165-MG-add-property-based-high-level-query-test
2023-01-19 16:22:46 +01:00
János Benjamin Antal
a31c7cce08
Merge pull request #702 from memgraph/T1189-MG-implement-create-node-cursor-mf
...
Implement CreateNode cursor with MultiFrame
2023-01-19 16:22:30 +01:00
János Benjamin Antal
8f6fac3cde
Make arguments const
2023-01-19 14:35:25 +01:00
gvolfing
a0ada914ab
Fix segfault
2023-01-19 13:10:53 +01:00
János Benjamin Antal
ca62fa5123
Fetch properties of destination vertex
2023-01-19 11:42:24 +01:00
János Benjamin Antal
d1548c9253
Eliminate fully
2023-01-19 10:43:54 +01:00
János Benjamin Antal
52baaf8030
Detect when no work should be done because of lack of input data in cursors
2023-01-19 10:43:07 +01:00
János Benjamin Antal
a0274bbdd9
Prevent reexecution of cursor when no output symbols are present
2023-01-19 10:42:09 +01:00
János Benjamin Antal
c5c6fd9b86
Merge branch 'T1190-MG-Implement-ScanAll-and-ScanAllByLabel-with-MultiFrame_2' into T1214-MG-implement-expand-with-multiframe
2023-01-18 22:22:21 +01:00
János Benjamin Antal
586999475b
Merge remote-tracking branch 'origin/T1189-MG-implement-create-node-cursor-mf' into T1190-MG-Implement-ScanAll-and-ScanAllByLabel-with-MultiFrame_2
2023-01-18 22:22:05 +01:00
János Benjamin Antal
e888464de2
Implement automaton for ExpandOneCursor
2023-01-18 17:32:22 +01:00
gvolfing
94a536a2b9
Fix hanging conditionvariable
2023-01-18 16:03:34 +01:00
János Benjamin Antal
e42c60d555
Merge branch 'project-pineapples' into T1189-MG-implement-create-node-cursor-mf
2023-01-18 13:37:36 +01:00
János Benjamin Antal
00d6b42c37
Merge pull request #699 from memgraph/T1191-MG-implement-create-expand-with-multiframe
2023-01-18 13:37:24 +01:00
János Benjamin Antal
f39a937323
Add first, but buggy implementation
2023-01-18 13:31:35 +01:00
János Benjamin Antal
575361827e
Add comment about invalid usage of MutliFrame
2023-01-17 21:01:54 +01:00
János Benjamin Antal
901da4c9b3
Update InvalidFramesPopulator to follow the conventions
2023-01-17 21:01:22 +01:00
János Benjamin Antal
81675106fd
Use tests namespace for tests
2023-01-17 20:33:14 +01:00
János Benjamin Antal
7fb828bca3
Update outdated comments
2023-01-17 20:32:00 +01:00
János Benjamin Antal
c04cfc5596
Merge branch 'T1191-MG-implement-create-expand-with-multiframe' into T1189-MG-implement-create-node-cursor-mf
2023-01-17 20:29:52 +01:00
János Benjamin Antal
a3b1676c42
Separate include blocks
2023-01-17 20:25:28 +01:00
János Benjamin Antal
b38a9b9c90
Use tests namespace for tests
2023-01-17 20:25:10 +01:00
János Benjamin Antal
57690c5390
Refactor DistributedScanAllAndFilterCursor
2023-01-17 08:34:08 +01:00
János Benjamin Antal
d11d5c3fa9
Make special member functions of MultiFrame iterators consistent
2023-01-17 08:33:40 +01:00
János Benjamin Antal
36891c119b
Remove unnecessary state from DistributedScanAllAndFilterCursor
2023-01-17 07:17:53 +01:00
János Benjamin Antal
b91b16de96
Fix Interpreter::PullMultiple for queries that return some values
2023-01-17 07:06:25 +01:00
gvolfing
cfdc728d64
Merge branch 'project-pineapples' into T1165-MG-add-property-based-high-level-query-test
2023-01-16 16:26:33 +01:00
gvolfing
40835b8c9c
General clean-up
2023-01-16 14:54:20 +01:00
gvolfing
d1fe73c987
Conform simulation to test GetProperties correctly
2023-01-16 14:05:13 +01:00
gvolfing
3257d46d18
Remove assertion
2023-01-16 13:44:02 +01:00
gvolfing
9be5ee1ae9
Make GetProperties return the PrimaryKeys as well, when queried for all properties like ScanAll
2023-01-16 13:26:33 +01:00
gvolfing
fdd89e0e81
Replace ScanVertices with GetProperties request, in the case of ScanAllByPrimaryKey operator
2023-01-16 11:27:41 +01:00
János Benjamin Antal
82203fa1ca
Merge branch 'T1189-MG-implement-create-node-cursor-mf' into T1190-MG-Implement-ScanAll-and-ScanAllByLabel-with-MultiFrame_2
2023-01-16 10:44:58 +01:00
János Benjamin Antal
775e950dba
Update unit tests to test the new logic
2023-01-16 10:16:12 +01:00
János Benjamin Antal
920ad277a5
Add assertion about primary label
2023-01-16 09:03:35 +01:00
János Benjamin Antal
392f6e2b73
Reduce the number of node infos to a maximum of one
2023-01-16 08:57:23 +01:00
János Benjamin Antal
e40f7f507b
Fix pull logic for multiframe
2023-01-16 08:40:43 +01:00
János Benjamin Antal
c139856b2a
Fix unit tests
2023-01-15 18:52:36 +01:00
János Benjamin Antal
b30137ab7a
Improve unit tests to catch bug
2023-01-15 18:39:58 +01:00
János Benjamin Antal
b2b9b1d5cb
Eliminate warnings about deprecated methods
2023-01-15 18:25:48 +01:00
János Benjamin Antal
ace1eb401f
Make unit tests compile with new gtest version
2023-01-15 18:25:32 +01:00
gvolfing
668f7857b1
Pass the correct expression to the operator
2023-01-13 12:38:50 +01:00
gvolfing
d22c962af4
Turn RequestRouter into an interface again
2023-01-12 21:25:40 +01:00
gvolfing
4c25a4dfbd
Remove unnecessary comments
2023-01-12 20:17:35 +01:00
gvolfing
61d84bd622
Set the type of the frame size to size_t from int64_t
2023-01-12 16:58:09 +01:00
gvolfing
3b06db5a02
Clang-tidy
2023-01-12 16:13:27 +01:00
gvolfing
afde0c6926
Remove outcommented code, conform clang-tidy
2023-01-12 15:45:14 +01:00
gvolfing
41bb988fe9
Fix failing benchmark tests and implement cursor
...
The benchmarking tests were failing because of the incorrect
implementation of the ScanAllByPrimaryKeyCursor. The previous
implementation caused the currently allocateable 1m edgeids to run out
very quickly, causing the the tests to freeze.
2023-01-12 14:14:59 +01:00
János Benjamin Antal
d7bd2cc754
Eliminate copying expands
2023-01-12 09:05:29 +01:00
János Benjamin Antal
599b133a55
Fix edge direction when creating edges
2023-01-12 09:04:18 +01:00
jeremy
c38a80ccd7
Merge branch 'T1190-MG-Implement-ScanAll-and-ScanAllByLabel-with-MultiFrame_2' into T1216-MG-implement-aggregate
2023-01-03 14:58:48 +01:00
jeremy
dee33b2072
Merge branch 'T1189-MG-implement-create-node-cursor-mf' into T1190-MG-Implement-ScanAll-and-ScanAllByLabel-with-MultiFrame_2
2023-01-03 14:58:21 +01:00
jeremy
c283c6e6ea
Merge branch 'T1191-MG-implement-create-expand-with-multiframe' into T1189-MG-implement-create-node-cursor-mf
2023-01-03 14:57:02 +01:00
Jeremy B
65113bc55b
Merge branch 'project-pineapples' into T1191-MG-implement-create-expand-with-multiframe
2023-01-03 14:55:56 +01:00
gvolfing
32ea124d4b
Merge branch 'project-pineapples' into T1167-MG-create-scanbyprimarykey-operator
2023-01-02 13:37:07 +01:00
gvolfing
68175bc97c
Init basic cursor class
...
Conform clang-tidy and modify PullMultiple behavior
2023-01-02 13:05:44 +01:00
jeremy
9589dd97b6
Impl and correct aggregate
2022-12-30 16:21:41 +01:00
Jure Bajic
41f5c00f5f
Merge pull request #680 from memgraph/T1185-MG-replace-skip-list
...
- Replace `SkipList` with `std::map` as vertex container
- Replace `SkipList` with `std::map` as edge container
- Replace `SkipList` with `std::set` as `LabelPropertyIndex` container
- Replace `SkipList` with `std::set` as `LabelIndex` container
- Remove `KeyStore` and `LexicographiOrderedVertex`
2022-12-20 16:36:55 +01:00
jbajic
e82955895a
Leave a TODO
2022-12-20 16:14:01 +01:00
jeremy
751c27f792
Get ride of attribute has_valid_frames_
2022-12-20 10:12:50 +01:00
jeremy
7e217e94b3
Tests: CreateMultiFrame create invalid frames
...
Test uses real "once" instead of mocked version
2022-12-19 15:44:01 +01:00
gvolfing
1ebde8be74
Merge branch 'project-pineapples' into T1165-MG-add-property-based-high-level-query-test
2022-12-15 17:21:39 +01:00
gvolfing
32231fe49a
Move the implementation of AllocateInitialEdgeIds into the child class
2022-12-15 17:10:27 +01:00
gvolfing
fa39c6740b
Apply review comments
2022-12-15 17:02:01 +01:00
jeremy
1aa40e5e3f
Add const to method
2022-12-15 16:24:45 +01:00
gvolfing
ae57fa3199
Apply suggestions from code review
...
Co-authored-by: Kostas Kyrimis <kostaskyrim@gmail.com >
2022-12-15 15:25:46 +01:00
jbajic
a0e0791aa1
Address review comments
2022-12-15 14:52:13 +01:00
jeremy
311994a36d
Impl of version more memory friendly
2022-12-15 14:40:20 +01:00
jeremy
54ce79baa0
Add empty line
2022-12-15 14:40:20 +01:00
jeremy
83306d21de
Revert changes
2022-12-15 14:40:20 +01:00
jeremy
ac16348fff
Remove unused variable
2022-12-15 14:40:20 +01:00
jeremy
af812d1311
Implement scanAll MultiFrame version
2022-12-15 14:40:20 +01:00
gvolfing
f36b96744c
Apply post-merge fixes
2022-12-15 11:04:20 +01:00
gvolfing
14000d727f
Merge branch 'project-pineapples' into T1167-MG-create-scanbyprimarykey-operator
2022-12-15 10:26:36 +01:00
Kostas Kyrimis
a9eca651df
Address GH comments and fix a bug in ValidFramesModifier postincrement
2022-12-14 18:26:40 +02:00
gvolfing
3604046f68
Implement cypher query based simulation testing
...
Make the Interpreter be able to handle SimulatorTransport as well. This
includes introducing changes that make it possible to use the different
transport types in a semi-polymorphic way with the introduction of
factory methods in the RequestRouter. The reason for this solution is
that the classes that represent the different transport types have
member function templates, that we can not make virtual. This solution
seemed to be the least convoluted. In the testing itself now it is
possible to pass a set of cypher queried to the interpreter which would
run these queries against the interpreter and the individual shards that
are managed and started up by the MachineManager with the different
entities communicating over the simulated network.
2022-12-14 13:55:45 +01:00
jbajic
817433d342
Revert to approximate
2022-12-13 13:32:14 +01:00
jbajic
76dcf3ad0f
Use std::set in LabelIndex
2022-12-13 13:21:52 +01:00
Kostas Kyrimis
04450dada7
Simplify tests
2022-12-12 19:23:40 +02:00
Kostas Kyrimis
8c2b2f4be2
Merge branch 'T1191-MG-implement-create-expand-with-multiframe' into T1189-MG-implement-create-node-cursor-mf
2022-12-12 19:17:43 +02:00
Kostas Kyrimis
70200919cd
Merge branch 'project-pineapples' into T1191-MG-implement-create-expand-with-multiframe
2022-12-12 19:16:05 +02:00
Kostas Kyrimis
f04ed3c137
Simplify Mocks and test
2022-12-12 19:15:49 +02:00
Kostas Kyrimis
2e4e975102
Update GoogleTest lib to latest release version 1.12.1
2022-12-12 19:15:28 +02:00
Jure Bajic
c24c699c78
Merge branch 'project-pineapples' into T1185-MG-replace-skip-list
2022-12-12 08:01:47 -08:00
Tyler Neely
070225df28
Merge pull request #708 from memgraph/tyler_shard_struct
...
[project-pineapples <-] Make coordinator::Shard into a proper struct named ShardMetadata
2022-12-12 16:51:54 +01:00
Tyler Neely
1170e6762f
Rename coordinator::Shard to coordinator::ShardMetadata to avoid conflation with storage::v3::Shard
2022-12-12 15:22:17 +00:00
Tyler Neely
d6f1505582
Make Shard into a proper struct that can contain additional metadata
2022-12-12 15:14:48 +00:00
jbajic
edb122cb33
Fix benchmark tests
2022-12-12 16:01:20 +01:00
jbajic
b0c4544287
Add asserts
2022-12-12 15:46:41 +01:00
Jure Bajic
0d856bee45
Merge branch 'project-pineapples' into T1185-MG-replace-skip-list
2022-12-12 05:45:09 -08:00
jbajic
c3e19498da
Replace LabelPropertyIndex with std::set
2022-12-12 14:44:58 +01:00
Jure Bajic
03d994318e
Merge pull request #668 from memgraph/T1173-MG-benchmark-datastructures
...
- Add benchmarks comparing insert, remove, find and contains for std::map, std::set and utils::SkipList-
- Create a python plot script
- Create a bash helper script for executing and plotting benchmarks
2022-12-12 04:11:55 -08:00
Jure Bajic
4888605972
Merge branch 'project-pineapples' into T1173-MG-benchmark-datastructures
2022-12-12 03:46:49 -08:00
jbajic
a90a2d86c9
Fix edge test
2022-12-12 12:46:13 +01:00
jbajic
0cf440519e
Introduce VertexData
2022-12-12 12:39:49 +01:00
Jeremy B
9c41e702e6
Merge pull request #703 from memgraph/T1190-correct-ValidFramesConsumer-begin
...
[🍍 < T1190] Correct implementation of begin iterators
Correct implementation of MultiFrame iterators::begin. If no Frames are valid, we need to return end()
2022-12-09 12:56:31 +01:00
jeremy
50f76b926b
Make MultiFrame pointer instead of ref inside impl of iterators
2022-12-09 12:20:01 +01:00
jeremy
0353262cc2
Correct impl of begin iterators
2022-12-09 12:10:48 +01:00
Kostas Kyrimis
4ed20f0247
Add prototype for CreateNode multiframe
2022-12-08 18:46:30 +02:00
Jure Bajic
50fb8fe3c7
Merge branch 'project-pineapples' into T1173-MG-benchmark-datastructures
2022-12-08 04:41:34 -08:00
Jure Bajic
32322d39b8
Merge branch 'project-pineapples' into T1185-MG-replace-skip-list
2022-12-08 04:40:02 -08:00
Kostas Kyrimis
89f42ef73e
Add CreateExpand PullMultiple and prototype mocks for testing
2022-12-07 19:03:30 +02:00
Kostas Kyrimis
0d19d347f8
Merge pull request #695 from memgraph/T1163-remove-template-from-frame
2022-12-06 13:57:50 +02:00
Kostas Kyrimis
a5520f5eae
Merge branch 'project-pineapples' into T1163-remove-template-from-frame
2022-12-06 13:24:55 +02:00
Jure Bajic
eb154d1310
Merge branch 'project-pineapples' into T1173-MG-benchmark-datastructures
2022-12-06 03:08:26 -08:00
Tyler Neely
59c94c90e6
Merge pull request #690 from memgraph/tyler_full_async_request_router
...
[project-pineapples <-] full async request router
2022-12-06 11:50:59 +01:00
jbajic
a7f5212c6e
Merge branch 'T1173-MG-benchmark-datastructures' of github.com:memgraph/memgraph into T1173-MG-benchmark-datastructures
2022-12-06 11:47:57 +01:00
jbajic
b4d6ca2233
Use bool as data
2022-12-06 11:47:48 +01:00
Tyler Neely
5d3d67cbd0
Rename unsent_requests to requests_to_be_sent in RequestRouter
2022-12-06 10:32:57 +00:00
Tyler Neely
675c2fe24a
Update src/io/rsm/rsm_client.hpp
...
Co-authored-by: Jeremy B <97525434+42jeremy@users.noreply.github.com >
2022-12-06 11:31:46 +01:00
Tyler Neely
b288f06cb7
Update src/io/rsm/rsm_client.hpp
...
Co-authored-by: Jeremy B <97525434+42jeremy@users.noreply.github.com >
2022-12-06 11:31:40 +01:00
Jure Bajic
5beb7c0966
Merge branch 'project-pineapples' into T1173-MG-benchmark-datastructures
2022-12-05 07:00:30 -08:00
jbajic
e0b7d7abeb
Address review comments
2022-12-05 16:00:17 +01:00
Jure Bajic
9bab26fb10
Apply suggestions from code review
...
Co-authored-by: Kostas Kyrimis <kostaskyrim@gmail.com >
2022-12-05 15:50:40 +01:00
Jure Bajic
c39f264684
Merge branch 'project-pineapples' into T1185-MG-replace-skip-list
2022-12-05 06:37:43 -08:00
jbajic
2488895362
Rename ApproximateVertexCount to VertexCount
2022-12-05 15:37:10 +01:00
jbajic
a20edf2b74
Fix bounds
2022-12-05 15:30:39 +01:00
Tyler Neely
25713405df
Update src/io/simulator/simulator_transport.hpp
...
Co-authored-by: gvolfing <107616712+gvolfing@users.noreply.github.com >
2022-12-05 15:26:29 +01:00
Tyler Neely
2a81ce5640
Update src/io/simulator/simulator.hpp
...
Co-authored-by: gvolfing <107616712+gvolfing@users.noreply.github.com >
2022-12-05 15:26:18 +01:00
Tyler Neely
747b8a21cd
Fix bug with polling redirected requests
2022-12-05 14:20:06 +00:00
jbajic
65e9ceb779
Use multimap as index structure
2022-12-05 14:52:51 +01:00
Jeremy B
6338690b00
Merge branch 'project-pineapples' into T1163-remove-template-from-frame
2022-12-05 14:45:54 +01:00
Tyler Neely
ca3f748325
Apply clang-tidy feedback
2022-12-05 13:43:20 +00:00
Tyler Neely
1b458ebc41
Complete migration of GetProperties to new request style
2022-12-05 13:26:44 +00:00
Tyler Neely
6efe074313
Update GetProperties to use the correct style of request driving in the RequestRouter
2022-12-05 13:15:12 +00:00
Tyler Neely
3c72af0c10
Merge branch 'project-pineapples' into tyler_full_async_request_router
2022-12-05 14:09:23 +01:00
jeremy
6d3f9ab695
Removing template from class Frame
2022-12-05 14:07:53 +01:00
Kostas Kyrimis
e8240df29e
Merge pull request #694 from memgraph/T1188-MG-remove-unused-txt
2022-12-05 13:18:38 +02:00
Kostas Kyrimis
ec73ee666c
Remove unused jba.txt
2022-12-05 13:02:33 +02:00
János Benjamin Antal
1d7f61dd0b
Merge pull request #676 from memgraph/T1163-MG-add-multiframe-and-some-operators
...
Implement MultiFrame with iterators
2022-12-05 11:51:11 +01:00
jeremy
7f9eceadb3
Remove un-needed frame modification in Once
...
This is not needed and would be incorrect with the optional
2022-12-05 11:19:47 +01:00
jeremy
f4428af210
Remove reference function on operator++() &
2022-12-05 11:05:47 +01:00
jeremy
9f5af97044
Merge branch 'T1163-MG-add-multiframe-and-some-operators' of github.com:memgraph/memgraph into T1163-MG-add-multiframe-and-some-operators
2022-12-05 10:38:06 +01:00
jeremy
c7c0234889
Add default constructor to iterators
2022-12-05 10:38:01 +01:00
Jeremy B
68ae729b07
Update src/query/v2/multiframe.hpp
...
Co-authored-by: János Benjamin Antal <antaljanosbenjamin@users.noreply.github.com >
2022-12-05 10:34:58 +01:00
Tyler Neely
2e33f8275b
Merge branch 'project-pineapples' into tyler_full_async_request_router
2022-12-02 19:05:15 +01:00
Tyler Neely
9a62503803
Tick the simulator forward from Notify::Await in a similar way that Future::Wait does
2022-12-02 18:04:38 +00:00
Jure Bajic
75b598d014
Merge branch 'project-pineapples' into T1173-MG-benchmark-datastructures
2022-12-02 07:28:39 -08:00
Kostas Kyrimis
98ae30d861
Merge branch 'project-pineapples' into T1163-MG-add-multiframe-and-some-operators
2022-12-02 15:12:02 +02:00
Kostas Kyrimis
6b8a5fd41d
Make all variants of multiframe iterators model ForwardIterator concept properly
2022-12-02 15:11:51 +02:00
jbajic
4a3f950cf9
Fix indices
2022-12-02 10:17:26 +01:00
Kostas Kyrimis
146ed5756c
Merge pull request #666 from memgraph/T1172-MG-implement-get-properties-on-qe
2022-12-01 19:14:20 +02:00
Tyler Neely
438b519703
Apply clang-tidy feedback
2022-12-01 16:26:41 +00:00
Kostas Kyrimis
0ad702175f
Fix expression evaluator mocked request router
2022-12-01 18:24:51 +02:00
jeremy
be3797e0a1
Remove unused param
2022-12-01 17:01:08 +01:00
Tyler Neely
cdde7ca670
Merge branch 'project-pineapples' into tyler_full_async_request_router
2022-12-01 17:00:09 +01:00
jeremy
d0e1d86df3
Remove unused param
2022-12-01 16:57:09 +01:00
Tyler Neely
366a4e2b9a
Add support for efficiently executing multiple asynchronous requests out-of-order from the RequestRouter
2022-12-01 15:56:16 +00:00
Kostas Kyrimis
439eae3a72
Merge branch 'project-pineapples' into T1172-MG-implement-get-properties-on-qe
2022-12-01 17:42:01 +02:00
Kostas Kyrimis
c15e75b48c
Remove old shard request manager header
2022-12-01 17:40:58 +02:00
Kostas Kyrimis
2120645d6a
Remove dead code in request_router simulation test
2022-12-01 17:39:12 +02:00
Jeremy B
616b79ce6c
Merge branch 'project-pineapples' into T1163-MG-add-multiframe-and-some-operators
2022-12-01 16:36:59 +01:00
jeremy
13cabcaab5
Re-implement ValidFramesReader and iterators
2022-12-01 16:31:21 +01:00
Kostas Kyrimis
f1ea76a3d7
Merge branch 'T0919-MG-implement-get-properties-storage' into T1172-MG-implement-get-properties-on-qe
2022-12-01 17:19:00 +02:00
Kostas Kyrimis
18b3c1e8b1
Merge pull request #652 from memgraph/T0919-MG-implement-get-properties-storage
...
Implements GetProperties request handler on shard_rsm
2022-12-01 17:15:15 +02:00
jeremy
db45845619
format
2022-12-01 15:52:35 +01:00
Jeremy B
4bbf3c95ca
Update src/query/v2/multiframe.cpp
...
Co-authored-by: János Benjamin Antal <antaljanosbenjamin@users.noreply.github.com >
2022-12-01 15:49:17 +01:00
jeremy
e11856acf8
Merge branch 'T1163-MG-add-multiframe-and-some-operators' of github.com:memgraph/memgraph into T1163-MG-add-multiframe-and-some-operators
2022-12-01 15:19:40 +01:00
Jeremy B
5cd0d5137e
Update src/query/v2/multiframe.hpp
...
Co-authored-by: Kostas Kyrimis <kostaskyrim@gmail.com >
2022-12-01 15:18:50 +01:00
jeremy
8eec8399a3
Rmove unneeded "this"
2022-12-01 15:04:51 +01:00
jeremy
d18d4f198e
Merge branch 'T1163-MG-add-multiframe-and-some-operators' of github.com:memgraph/memgraph into T1163-MG-add-multiframe-and-some-operators
2022-12-01 14:55:45 +01:00
jeremy
29347c83e7
Remove unneeded tag
2022-12-01 14:54:26 +01:00
Jeremy B
452722f4f8
Update src/query/v2/multiframe.hpp
...
Co-authored-by: Kostas Kyrimis <kostaskyrim@gmail.com >
2022-12-01 14:52:30 +01:00
jbajic
730bac6b74
Replace edges skiplist
2022-12-01 14:32:33 +01:00
Jeremy B
6c441b80ec
Update src/query/v2/multiframe.hpp
...
Co-authored-by: Kostas Kyrimis <kostaskyrim@gmail.com >
2022-12-01 14:20:57 +01:00
Jeremy B
ee9ba1a7f8
Update src/query/v2/multiframe.hpp
...
Co-authored-by: Kostas Kyrimis <kostaskyrim@gmail.com >
2022-12-01 14:20:26 +01:00
Jeremy B
d0c960e900
Update src/query/v2/multiframe.hpp
...
Co-authored-by: Kostas Kyrimis <kostaskyrim@gmail.com >
2022-12-01 14:20:19 +01:00
jeremy
00fd69c170
Add statement to ignroe clang warning
2022-12-01 14:19:41 +01:00
Jeremy B
54907d2a1a
Update src/query/v2/multiframe.cpp
...
Co-authored-by: Kostas Kyrimis <kostaskyrim@gmail.com >
2022-12-01 14:19:15 +01:00
jeremy
23bfd7f4fc
Updated OnceCursor
2022-12-01 13:45:24 +01:00
Kostas Kyrimis
f8cbaaf362
Allow requests with zero properties
2022-12-01 14:41:21 +02:00
jbajic
4e7d8c3ba2
Replace LabelPropertyIndex skiplist with std::map
2022-12-01 12:06:01 +01:00
jeremy
e5d892683c
Keep wraper as ptr instead of ref
2022-12-01 11:14:54 +01:00
jbajic
d4bdedd9e8
Fix GetProperty
2022-11-30 17:12:09 +01:00
jeremy
9f9a81455f
Change type size_t->int64_t
2022-11-30 16:56:35 +01:00
jeremy
b0b8c0a5c9
Add noexcept to basic functions
2022-11-30 16:49:32 +01:00
Kostas Kyrimis
8af635c8d7
Fix clang-tidy warnings
2022-11-30 17:44:37 +02:00
jeremy
5e64b19745
Replace pull_count_->did_pull_
2022-11-30 16:30:55 +01:00
jeremy
38f3a4cacb
Use range for loop instead of idx based
2022-11-30 16:28:01 +01:00
Kostas Kyrimis
3f3d6c52a3
Merge branch 'project-pineapples' into T0919-MG-implement-get-properties-storage
2022-11-30 17:25:05 +02:00
Kostas Kyrimis
94ef57c459
Fix small bugs
2022-11-30 17:24:46 +02:00
jeremy
56556f7c2d
Update incorrect de-referencing
2022-11-30 16:22:39 +01:00
jeremy
a2027fc6ac
Remove default_frame
2022-11-30 16:09:06 +01:00
jeremy
deb31e4b77
Multiframe only expects size of frame instead of default frame
2022-11-30 16:00:24 +01:00
jeremy
072bc58b1e
Reverse condition in while() + comment
2022-11-30 14:50:28 +01:00
jbajic
31f907cb53
Remove keystore
2022-11-30 14:40:12 +01:00
jbajic
9af20c295c
Fix VerticesContainer being passed by value
2022-11-30 14:39:52 +01:00
jeremy
969b8f0da7
Remove un-necessary internal_ptr
2022-11-30 14:32:19 +01:00
jeremy
55008a2927
Rename func ResetAllFramesInvalid->MakeAllFramesInvalid
2022-11-30 14:17:01 +01:00
Jure Bajic
494f6ac25f
Merge branch 'project-pineapples' into T1185-MG-replace-skip-list
2022-11-30 05:12:43 -08:00
jeremy
02ca6734c1
Correct comment to follow common style
2022-11-30 14:11:38 +01:00
jbajic
976e6ff0a6
Replace skiplist with std::set
2022-11-30 14:11:22 +01:00
Kostas Kyrimis
9621532d3d
Prototype suggested changes and polish PR
2022-11-30 14:59:00 +02:00
gvolfing
7e8b4921b4
Make query_v2_plan unit tests available again.
...
The query_v2_plan unit tests were needed in order to properly test if
the created logical plan of the new operator work properly. In order to
achieve this v2 versions of the several files were created, where the
old utilities were replaced with new ones, like query::v2 and
storage::v3. A new fake db accessor was also created in order to be able
to test the ScanAllByPrimaryKey operator.
2022-11-30 13:16:04 +01:00
jeremy
a10c254caa
Add // NOLINTNEXTLINE to correct place
2022-11-30 11:43:16 +01:00
jeremy
9c0c0a2d1c
Add clang warning suppress
2022-11-30 10:14:07 +01:00
Jure Bajic
0450163c5e
Merge branch 'project-pineapples' into T1173-MG-benchmark-datastructures
2022-11-30 00:17:13 -08:00
Jeremy B
62ee6f0e05
Merge branch 'project-pineapples' into T1163-MG-add-multiframe-and-some-operators
2022-11-29 17:34:16 +01:00
jeremy
00a4127e4e
Remove incorrect = default
2022-11-29 17:15:52 +01:00
Tyler Neely
53040c6758
Merge pull request #651 from memgraph/T1157-MG-concurrent-RsmClient-requests
...
Support concurrent RsmClient requests
2022-11-29 17:11:25 +01:00
Tyler Neely
04124a1e9b
Make AsyncRequestToken arguments const, reserve size in response vectors
2022-11-29 15:50:35 +00:00
jeremy
f107ef8aea
Default destructor in header
2022-11-29 16:12:50 +01:00
Tyler Neely
b3605c9ab1
Fix typo in new simplified RequestRouter::CreateExpand method
2022-11-29 15:11:35 +00:00
Tyler Neely
7df3a743b9
Simplify and parallelize CreateExpand
2022-11-29 15:07:59 +00:00
Tyler Neely
f8215306e8
A variety of small code clean-ups, remove overloaded methods
2022-11-29 15:06:01 +00:00
Tyler Neely
8f08d986cb
Make method names clear for RequestRouter requests, avoid unnecessary overloading
2022-11-29 14:47:32 +00:00
jeremy
cc3bcf1dc2
Clang tidy
2022-11-29 15:43:24 +01:00
Tyler Neely
9144d2dccd
Remove bug-prone inverted ownership of ExecutionState as a consideration of operators
2022-11-29 14:30:59 +00:00
jeremy
9faa206f95
Clang tidy
2022-11-29 15:03:03 +01:00
jbajic
1b97bb0856
Remove redundant line from skiplist
2022-11-29 14:57:53 +01:00
Jure Bajic
f54701cc96
Merge branch 'project-pineapples' into T1173-MG-benchmark-datastructures
2022-11-29 05:55:29 -08:00
jbajic
1f98d33fa6
Remove b++ tree
2022-11-29 14:40:44 +01:00
jeremy
86f7b82bdc
Clang tidy
2022-11-29 14:26:17 +01:00
jeremy
8c5edaaeb9
Update type
2022-11-29 14:07:15 +01:00
jbajic
632db4175a
Revert storage changes
2022-11-29 14:04:12 +01:00
jeremy
3c0e38aacb
Adapt comment
2022-11-29 13:54:26 +01:00
jeremy
aace5db8cc
Adapt comment
2022-11-29 13:53:08 +01:00
jeremy
bc32a3d305
Adapt comment
2022-11-29 13:52:29 +01:00
jeremy
cead1bcb21
Rename ValidFramesInvalidator->ValidFramesConsumer
2022-11-29 13:49:37 +01:00
Tyler Neely
ec529da8d2
Address clang-tidy feedback
2022-11-29 12:28:19 +00:00
jbajic
ce5f1c2f17
Add memory runner for insert
2022-11-29 13:27:28 +01:00
Tyler Neely
1b77e029ca
Use the Async methods under the hood for the blocking RsmClient::Send*Request methods for code-reuse
2022-11-29 11:33:49 +00:00
jeremy
16c30d61aa
Merge branch 'T1163-MG-add-multiframe-and-some-operators' of github.com:memgraph/memgraph into T1163-MG-add-multiframe-and-some-operators
2022-11-29 12:30:11 +01:00
Jeremy B
b8de2c9c7a
Merge branch 'project-pineapples' into T1163-MG-add-multiframe-and-some-operators
2022-11-29 12:30:00 +01:00
jeremy
cd0aaeb5e9
Merge branch 'T1163-MG-add-multiframe-and-some-operators' of github.com:memgraph/memgraph into T1163-MG-add-multiframe-and-some-operators
2022-11-29 12:29:59 +01:00
Jeremy B
cf388d80fc
Update src/query/v2/plan/operator.lcp
2022-11-29 12:29:52 +01:00
Tyler Neely
a308ee501a
Unify the driving of read and write requests in the RequestRouter
2022-11-29 11:25:29 +00:00
jbajic
884831ece5
Use pk
2022-11-29 11:56:01 +01:00
Tyler Neely
aa7d362296
Merge branch 'project-pineapples' of github.com:memgraph/memgraph into T1157-MG-concurrent-RsmClient-requests
2022-11-29 10:13:42 +00:00
jeremy
e946eb50d2
Add version ValidFramesModifier to distinguish between reading-only and reading+modifying
2022-11-29 11:05:11 +01:00
jeremy
8f19ce88d9
Rename ItOnNonConstInvalidFrames->InvalidFramesPopulator
2022-11-29 10:40:52 +01:00
jeremy
7c37ed2313
Rename ItOnNonConstValidFrames -> ValidFramesInvalidator
2022-11-29 10:38:01 +01:00
jeremy
11119e5406
Rename ItOnConstValidFrames->ValidFramesReader
2022-11-29 10:32:52 +01:00
Tyler Neely
7d52eedb21
Merge pull request #674 from memgraph/tyler_rename_ShardRequestManager_to_RequestRouter
...
[project-pineapples <- ] Rename ShardRequestManager to RequestRouter
2022-11-29 10:29:42 +01:00
Tyler Neely
4f18fa7431
Fix LCP that broke with invisible merge conflict
2022-11-29 09:07:18 +00:00
Tyler Neely
9f10c3ea06
Merge branch 'project-pineapples' of github.com:memgraph/memgraph into tyler_rename_ShardRequestManager_to_RequestRouter
2022-11-29 08:57:28 +00:00
Jeremy B
18b3550dbe
Merge branch 'project-pineapples' into T1163-MG-add-multiframe-and-some-operators
2022-11-28 17:34:07 +01:00
jeremy
b244c4d6ee
Impl of Multiframe and iterators
2022-11-28 17:32:29 +01:00
Kostas Kyrimis
4dc639a05a
Merge pull request #644 from memgraph/T1159-MG-Add-memgraph-functions
...
Add mg-functions lib, expression evaluator units and e2e tests
2022-11-28 18:18:58 +02:00
Kostas Kyrimis
50df0d4d53
Fix python imports and replace const char array with constexpr
2022-11-28 17:31:41 +02:00
jbajic
5f5d839f0c
Update analyzer script
2022-11-28 16:28:36 +01:00
gvolfing
22e3164e60
Add missing license
2022-11-28 16:18:28 +01:00
Kostas Kyrimis
8fd7327fbd
Address GH comments
2022-11-28 15:38:12 +02:00
jbajic
500691318a
Add analyze script
2022-11-28 14:15:41 +01:00
Tyler Neely
9fc7f9dced
Standardize RequestRouter variable names as request_router
2022-11-28 13:03:07 +00:00
Tyler Neely
82db1d4ad8
Rename ShardRequestManager to RequestRouter
2022-11-28 12:38:38 +00:00
Kostas Kyrimis
ed0b67dfdb
Fix compilation issues of the merge
2022-11-28 13:38:12 +02:00
Kostas Kyrimis
0f34c49e21
Merge branch 'project-pineapples' into T1159-MG-Add-memgraph-functions
2022-11-28 13:18:51 +02:00
Tyler Neely
f4d0c7769e
Merge pull request #670 from memgraph/tyler_set_proper_namespace_for_ShardRequestManager
...
Change the namespace of ShardRequestManager to query::v2 instead of msgs
2022-11-28 11:31:09 +01:00
Tyler Neely
6d3c04bd61
Address clang-tidy feedback
2022-11-28 10:09:59 +00:00
Tyler Neely
a8dc6fd41e
Change the namespace of ShardRequestManager to query::v2 instead of msgs
2022-11-28 09:43:56 +00:00
Tyler Neely
de84d4d6ea
Merge branch 'project-pineapples' of github.com:memgraph/memgraph into T1157-MG-concurrent-RsmClient-requests
2022-11-28 08:53:21 +00:00
jbajic
36a7abb170
Add remove benchmark
2022-11-27 22:50:36 +01:00
jbajic
41b06a0a37
Extract common functionalities
2022-11-27 22:28:23 +01:00
jbajic
cceab46a7c
Add find benchmark
2022-11-27 21:59:18 +01:00
jbajic
243fa5e4b2
Add insert benchmark
2022-11-27 21:21:55 +01:00
Marko Budiselic
0220e9b4f7
Add multiframe benchmark plot
2022-11-27 13:29:23 +01:00
Kostas Kyrimis
6f4996de0e
Fix broken merge and address GH comments
2022-11-25 16:20:38 +02:00
Kostas Kyrimis
01d5953bb6
Merge branch 'project-pineapples' into T1159-MG-Add-memgraph-functions
2022-11-25 15:47:44 +02:00
János Benjamin Antal
6b64fd5ce5
Merge pull request #664 from memgraph/MG-implicit-fallthrough-as-error
...
Make implicit-fallthrough a compilation error
2022-11-24 19:32:59 +01:00
jbajic
c5138c8d58
Add b+ tree
2022-11-24 17:45:43 +01:00
jbajic
8fe1b8d7fc
Add std::map and skiplist benchamrk
2022-11-24 17:44:41 +01:00
Kostas Kyrimis
7a3caa320c
WiP
2022-11-24 15:29:51 +02:00
Kostas Kyrimis
07a8ac0db8
Merge branch 'project-pineapples' into T0919-MG-implement-get-properties-storage
2022-11-24 15:29:05 +02:00
János Benjamin Antal
3b798ab313
Merge branch 'project-pineapples' into MG-implicit-fallthrough-as-error
2022-11-24 11:16:57 +01:00
János Benjamin Antal
d44c1836c7
Merge pull request #649 from memgraph/T0995-MG-implement-top-error-handling-storage
...
Implement top level error handling in storage
2022-11-24 11:14:59 +01:00
János Benjamin Antal
c4327cfb00
Make implicit-fallthrough a compilation error
2022-11-24 11:13:55 +01:00
gvolfing
a65ea4fe01
Conform clang-tidy
2022-11-24 09:37:47 +01:00
jbajic
d820d0a9e5
Fix clang tidy errors
2022-11-23 22:29:03 +01:00
jbajic
7aa68164f0
Merge branch 'project-pineapples' into T0995-MG-implement-top-error-handling-storage
2022-11-23 21:55:08 +01:00
jbajic
d6b444c38b
Log transaction id
2022-11-23 18:02:00 +01:00
János Benjamin Antal
c647134916
Merge pull request #611 from memgraph/T1083-MG-limit-and-order-expand-one_v3
...
Add Limit and OrderBy to ExpandOne
2022-11-23 17:37:32 +01:00
jbajic
b3eec92525
Merge branch 'project-pineapples' into T0995-MG-implement-top-error-handling-storage
2022-11-23 16:11:58 +01:00
gvolfing
1b73ca4860
Remove ScanAllById operator
2022-11-23 16:04:09 +01:00
jbajic
ab5fc05fd7
Address review comments
2022-11-23 15:32:28 +01:00
gvolfing
814c5eb397
Add the possibility of primary-key based indexing
...
Add new possibility to base our indexing solution on. Add
ScanAllOperator that represents the semantics and integrate its use
through index_lookup.
2022-11-23 15:15:26 +01:00
jeremy
e77843f2ec
Merge branch 'project-pineapples' into T1083-MG-limit-and-order-expand-one_v3
2022-11-23 14:47:29 +01:00
János Benjamin Antal
40e145e7d0
Merge pull request #646 from memgraph/T1116-MG-update-delete-vertex-labels
...
Update/Delete vertex labels
2022-11-23 14:35:11 +01:00
Kostas Kyrimis
2ff81ebf04
Address missed GH comments && fix broken merge
2022-11-23 15:16:14 +02:00
jeremy
c3c68cc2ce
Merge branch 'T1083-MG-limit-and-order-expand-one_v3' of github.com:memgraph/memgraph into T1083-MG-limit-and-order-expand-one_v3
2022-11-23 13:55:02 +01:00
jeremy
6d86801be0
Extract logic to convert ORderingDirection to Ordering
2022-11-23 13:54:54 +01:00
Kostas Kyrimis
407418e8f5
Merge branch 'project-pineapples' into T1159-MG-Add-memgraph-functions
2022-11-23 14:53:53 +02:00
Kostas Kyrimis
6d544e4fc0
Address GH comments
2022-11-23 14:51:38 +02:00
Jeremy B
56e2ad4546
Update src/storage/v3/shard_rsm.cpp
...
Co-authored-by: János Benjamin Antal <antaljanosbenjamin@users.noreply.github.com >
2022-11-23 13:24:35 +01:00
jbajic
9b19dd57d3
Remove storage include
2022-11-23 13:19:25 +01:00
Tyler Neely
5045323b1d
Merge branch 'project-pineapples' of github.com:memgraph/memgraph into T1157-MG-concurrent-RsmClient-requests
2022-11-23 11:31:14 +00:00
Jeremy B
aa146d28f8
Merge branch 'project-pineapples' into T1083-MG-limit-and-order-expand-one_v3
2022-11-23 12:26:58 +01:00
János Benjamin Antal
1cd10ab409
Merge branch 'project-pineapples' into T1116-MG-update-delete-vertex-labels
2022-11-23 12:15:34 +01:00
János Benjamin Antal
36390608aa
Merge pull request #648 from memgraph/MG-remove-unused-storage-files
...
Remove `storage.hpp` and `storage.cpp` files
2022-11-23 12:15:09 +01:00
Jure Bajic
e565fc6e3a
Merge branch 'project-pineapples' into T0995-MG-implement-top-error-handling-storage
2022-11-23 02:33:07 -08:00
jbajic
ce0f1a09f7
Remove unused methods from accessors
2022-11-23 11:32:53 +01:00
jbajic
accf015dcf
Fix clang-tidy errors
2022-11-23 11:03:17 +01:00
Jeremy B
84800cff76
Merge branch 'project-pineapples' into T1083-MG-limit-and-order-expand-one_v3
2022-11-23 10:57:05 +01:00
jbajic
9fade5ebac
Fix tests
2022-11-23 10:37:33 +01:00
Jure Bajic
75606dfeb0
Merge branch 'project-pineapples' into T1116-MG-update-delete-vertex-labels
2022-11-23 00:34:27 -08:00
János Benjamin Antal
9c36d8928a
Merge branch 'project-pineapples' into MG-remove-unused-storage-files
2022-11-23 09:19:14 +01:00
János Benjamin Antal
d926c4c4a4
Merge pull request #657 from memgraph/tyler_simulator_determinism_test
...
Improve simulator determinism
2022-11-23 09:14:25 +01:00
Kostas Kyrimis
9ec72bd969
Add GetProperties shard handler and tests
2022-11-22 19:44:22 +02:00
jeremy
85034ddcbe
Rename variable un function def
2022-11-22 17:29:02 +01:00
Tyler Neely
ea533f43fc
Print out the simulator seed when we exceed the configured abort_time
2022-11-22 16:06:57 +00:00
Tyler Neely
e0086e5666
Use spdlog::trace instead of info for simulator-related messages
2022-11-22 16:06:35 +00:00
Tyler Neely
c0a103e851
Do not advance the clock with every message, as this prevents messages of a certain request depth from ever completing
2022-11-22 16:00:06 +00:00
jeremy
3a171376d7
OrderBy in Expand has two members to differ vertices Vs edges
2022-11-22 16:47:25 +01:00
jbajic
cd7b33f23f
use comparison between ErrorCode and ShardError
2022-11-22 16:22:42 +01:00
jbajic
d82cfb349e
Use ShardResult
2022-11-22 15:00:32 +01:00
jeremy
6801d6ff09
Remove duplicate using statement
2022-11-22 14:49:54 +01:00
jbajic
f1e360469a
Expand SHARD_ERROR with fmt format
2022-11-22 14:44:28 +01:00
jeremy
307cce9e21
Remove unused struct
2022-11-22 14:23:24 +01:00
jeremy
662fa2e6d2
Remove uneeded using statement
2022-11-22 14:22:19 +01:00
jeremy
c0cb53e156
Replace if by switch
2022-11-22 14:20:22 +01:00
jeremy
742017548f
Merge branch 'T1083-MG-limit-and-order-expand-one_v3' of github.com:memgraph/memgraph into T1083-MG-limit-and-order-expand-one_v3
2022-11-22 14:11:48 +01:00
Jeremy B
bbbd722eeb
Update src/storage/v3/request_helper.hpp
...
Co-authored-by: Jure Bajic <jure.bajic@memgraph.com >
2022-11-22 14:11:29 +01:00
jeremy
f463d9f59f
Merge branch 'T1083-MG-limit-and-order-expand-one_v3' of github.com:memgraph/memgraph into T1083-MG-limit-and-order-expand-one_v3
2022-11-22 14:10:07 +01:00
Jeremy B
a6f3937692
Update src/storage/v3/request_helper.hpp
...
Co-authored-by: Jure Bajic <jure.bajic@memgraph.com >
2022-11-22 14:10:02 +01:00
jbajic
5717dfb165
Add ErrorCode to SHARD_ERROR macro
2022-11-22 14:05:04 +01:00
jeremy
1101c2444c
Make ConvertPropertyMap expect ref and not rvalue
2022-11-22 14:01:16 +01:00
jbajic
2a6dc7bb93
Remove success
2022-11-22 13:49:12 +01:00
jbajic
d080e260e6
Remove redundant code
2022-11-22 13:27:02 +01:00
jbajic
37f5fb29ea
Introduce BoltResult
2022-11-22 13:15:32 +01:00
Tyler Neely
c8c72de6ac
Use duration_cast to ensure that we are retrieving milliseconds inside SimulatorStats::operator<<
2022-11-22 11:30:24 +00:00
Tyler Neely
0b19b62b12
Set the abort_time for raft tests to 1 simulated hour
2022-11-22 11:25:24 +00:00
jbajic
bffef1a653
Use experimental source location
2022-11-22 11:13:23 +01:00
Tyler Neely
66f39f2681
Add elapsed time to the SimulatorStats
2022-11-22 08:55:48 +00:00
Tyler Neely
081c3e5bed
Capitalize unsigned integer literal
2022-11-21 13:16:35 +00:00
jeremy
ce8bc522d0
Clang warning
2022-11-21 12:23:04 +01:00
Tyler Neely
0f66ae31dd
Use explicit unsigned integer in right shift operation
2022-11-21 11:11:39 +00:00
jeremy
e9e42a0614
add * token to variable declaration
2022-11-21 11:50:56 +01:00
jeremy
1a67dec302
Update test to use OrderBy and Limit on Expand
2022-11-21 11:45:35 +01:00
jeremy
4eb673c7b9
Add const to variable
2022-11-21 11:31:22 +01:00
Tyler Neely
71dcba331e
Increment simulator time by up to 30ms in ticks
2022-11-21 10:10:45 +00:00
Tyler Neely
e43f4e2181
Sort simulator in_flight_ messages based on a stable sort of the sender address
2022-11-21 10:08:42 +00:00
jeremy
b2050d55ce
Add const
2022-11-21 10:59:38 +01:00
jeremy
2fc1aeb087
Remove unneeded using statements
2022-11-21 10:59:16 +01:00
jeremy
86e5b44c1c
Remove Shard::Accessor (unsued)
2022-11-21 10:42:15 +01:00
jeremy
1b0db5289d
OrderByVertices only keeps OrderBy expression which corresponds to Vertices
2022-11-21 10:41:08 +01:00
Tyler Neely
45badbe21f
Use unsigned integer literals for bit shifting in the NewShardUuid function
2022-11-18 17:22:50 +00:00
Tyler Neely
04420a84c7
Fix incorrect usage of IncrementServerCountAndWaitForQuiescentState in the shard_rsm.cpp simulation test
2022-11-18 16:54:38 +00:00
Tyler Neely
ce45a548c7
Significantly improve the determinism of the coordinator, UUID generation, the machine manager, the shard manager, and the cluster property test
2022-11-18 16:42:18 +00:00
Tyler Neely
3ad8489735
Run raft sim with random seeds over time, but allow a seed to be easily replayed using the RunWithSeed function
2022-11-18 10:34:21 +00:00
Tyler Neely
7115a7e75b
Apply clang-tidy fixes
2022-11-18 10:24:19 +00:00
Tyler Neely
0f32407bdc
Add compare header to histogram collector header
2022-11-18 10:20:45 +00:00
Tyler Neely
a37e7e4aff
Add assert to ensure TestAddress will not be higher than the uchar max
2022-11-18 10:19:55 +00:00
Tyler Neely
6b9a617df0
Streamline simulator tick condition varible notification. Advance time more aggressively
2022-11-18 09:20:15 +00:00
Tyler Neely
923325b8fa
Progress the simulator clock even when there are messages to deliver
2022-11-18 09:04:29 +00:00
Tyler Neely
f6017697d6
Make raft tests fully deterministic for rng_seeds between 0 and 500 at 1% message loss
2022-11-17 21:32:55 +00:00
Tyler Neely
9c3d683942
Explicitly join test threads before collecting test stats
2022-11-17 21:28:17 +00:00
Tyler Neely
cf73ed529d
Block messages from being delivered upon ShutDown
2022-11-17 21:27:48 +00:00
Tyler Neely
262df5c6a2
Avoid unordered_map in Raft code for more determinism
2022-11-17 21:24:13 +00:00
Tyler Neely
098084314e
Make TestAddress deterministically sortable
2022-11-17 21:22:41 +00:00
Tyler Neely
12880fc71a
Don't advance the simulator handle from server threads themselves
2022-11-17 18:27:12 +00:00
Tyler Neely
80d6776210
Improve simulator determinism
2022-11-17 17:36:46 +00:00
jeremy
3840c14846
Remove nocommit comment
2022-11-17 14:33:08 +01:00
jeremy
fe03f5b206
Update include to full path
...
add auto To variable declaration
2022-11-17 14:11:25 +01:00
jeremy
5f88e75571
Remove double declaration
2022-11-17 14:10:49 +01:00
jeremy
27495ef43a
Merge branch 'T1083-MG-limit-and-order-expand-one_v3' of github.com:memgraph/memgraph into T1083-MG-limit-and-order-expand-one_v3
2022-11-17 13:34:08 +01:00
jeremy
a499bf6dfd
Rename variable
2022-11-17 13:33:11 +01:00
Jeremy B
49652d0a61
Update src/storage/v3/shard_rsm.cpp
...
Co-authored-by: János Benjamin Antal <antaljanosbenjamin@users.noreply.github.com >
2022-11-17 13:32:48 +01:00
jeremy
6e44c2295d
Remove template from OrderByEdges + move to impl file
2022-11-17 13:30:39 +01:00
jeremy
d482f7da90
Merge branch 'T1083-MG-limit-and-order-expand-one_v3' of github.com:memgraph/memgraph into T1083-MG-limit-and-order-expand-one_v3
2022-11-17 12:59:37 +01:00
Jeremy B
77ab07d991
Update src/storage/v3/request_helper.hpp
...
Co-authored-by: János Benjamin Antal <antaljanosbenjamin@users.noreply.github.com >
2022-11-17 12:58:39 +01:00
jeremy
38b0b308ce
Remove unnecessary reserve
2022-11-17 12:58:28 +01:00
jeremy
2f55491271
use std::SameAsAnyOf i.o. is_sale_v
2022-11-17 12:45:15 +01:00
Jeremy B
68e51e73ba
Update src/storage/v3/shard_rsm.cpp
...
Co-authored-by: János Benjamin Antal <antaljanosbenjamin@users.noreply.github.com >
2022-11-17 12:42:36 +01:00
jeremy
a17a6aea5a
rename variable vertice->vertex
2022-11-17 12:27:12 +01:00
jbajic
ec4804b72a
Move ErrorCode to common
2022-11-17 11:03:03 +01:00
jbajic
e98ef634de
Ignore warning
2022-11-16 21:03:36 +01:00
jeremy
c4e22ffde3
Remove unnecessary tag
2022-11-16 18:51:57 +01:00
jeremy
b3ef0ccd71
Moving function from shard_rsm to helper files
2022-11-16 18:50:22 +01:00
jbajic
15fc3c0834
Fix error
2022-11-16 18:12:25 +01:00
jbajic
9261fabe60
Adapt for unfound object
2022-11-16 17:41:43 +01:00
jbajic
7bdcd8f9f4
Add shard_error in response
2022-11-16 14:48:06 +01:00
jeremy
bd11225d23
Use ref instead of optional
...
Use ref i.o. ptr
Rename variable for clarity
2022-11-16 14:14:35 +01:00
jbajic
1f159b5a80
Fix scheme test
2022-11-16 08:58:06 +01:00
jbajic
14ddd7254d
Fix communication and memgraph
2022-11-15 19:37:24 +01:00
jbajic
8629ee5ebc
Fix query v2
2022-11-15 19:30:34 +01:00
jbajic
1c94c59a24
Fix tests
2022-11-15 19:29:56 +01:00
Tyler Neely
631d18465b
Allow the RsmClient to store multiple in-flight requests. Update the ShardRequestManager to use the new request tokens and refactor some bug-prone aspects of it
2022-11-15 17:52:38 +00:00
jbajic
3f97a13493
Revert TError to Error
2022-11-15 18:30:25 +01:00
jbajic
5656a24c96
Remove unused exception
2022-11-15 18:25:25 +01:00
jbajic
9c05910e68
Adapt storage to new erro handling
2022-11-15 18:25:12 +01:00
jbajic
3d66bbd988
Remove shard_operation_result
2022-11-15 18:24:40 +01:00
jbajic
07032887a4
Adapt mg-expr
2022-11-15 18:24:28 +01:00
Kostas Kyrimis
9e81fe791c
Fix clang-tidy warnings, remove commented out code and add HasLabel
...
functions in ShardRequestManager to avoid throwing bad optional on
expression evaluator
2022-11-15 19:20:01 +02:00
jeremy
cca4e97bcf
Remove un-needed argument from OrderByEdges
2022-11-15 13:37:43 +01:00
Kostas Kyrimis
213583f916
Add expression evaluator && awesome_memgraph_functions unit tests
2022-11-14 20:46:20 +02:00
Kostas Kyrimis
94bc671551
Add awesome memgraph functions e2e tests
2022-11-14 20:46:19 +02:00
Kostas Kyrimis
02ef954e51
Add mg-functions lib and integrated with SE and QE
2022-11-14 20:46:16 +02:00
jeremy
131d7f2a74
OrderByElements: no longer templated over vertice/edge types. For edges, we always need to have access to the corresponding vertex_accessor (ex of sorting expr needing both : "vertex.map[edge]")
...
ComputeExpression: made assert instead of if check
2022-11-14 18:21:03 +01:00
jbajic
618237cc96
Adapt schema validator
2022-11-14 14:25:20 +01:00
jbajic
ef755e466c
Add ShardError
2022-11-14 14:15:29 +01:00
Jure Bajic
a9c5d40721
Update src/utils/template_utils.hpp
...
Co-authored-by: János Benjamin Antal <antaljanosbenjamin@users.noreply.github.com >
2022-11-14 10:32:18 +01:00
jbajic
b4c24f4506
Remvoe storage.hpp and storage.cpp files
2022-11-14 10:23:48 +01:00
jbajic
0462b8fc8f
Address review comments
2022-11-14 09:15:03 +01:00
jbajic
6eabceca4a
Add unit tests for UpdateVertex
2022-11-14 09:02:55 +01:00
jeremy
2045f54577
Correct merge issue
2022-11-09 21:36:41 +01:00
Jeremy B
18009c06b6
Merge branch 'project-pineapples' into T1083-MG-limit-and-order-expand-one_v3
2022-11-09 16:47:06 +01:00
Jure Bajic
db7b2aa59a
Merge branch 'project-pineapples' into T1116-MG-update-delete-vertex-labels
2022-11-09 07:24:26 -08:00
János Benjamin Antal
5c0e41ed44
Merge pull request #593 from memgraph/T1079-MG-add-simple-query-to-benchmark_v2
...
Add new dataset for mgbench
2022-11-09 16:21:56 +01:00
Jure Bajic
12e9c1a739
Merge branch 'project-pineapples' into T1116-MG-update-delete-vertex-labels
2022-11-09 07:08:04 -08:00
jbajic
a030419565
Move LogResultError to helper
2022-11-09 16:07:27 +01:00
jeremy
6df2db0d19
Remove comment force github workflow
2022-11-09 16:02:59 +01:00
jeremy
968584a8fc
Add comment force github workflow
2022-11-09 16:02:25 +01:00
jbajic
8636788ab2
Fix typos
2022-11-09 16:00:25 +01:00
jbajic
691f6af36d
Remove redundant code
2022-11-09 15:52:08 +01:00
jbajic
23f1536eac
Add tests
2022-11-09 15:42:09 +01:00
jeremy
33add3ecd0
Force formatting
2022-11-09 15:38:51 +01:00
János Benjamin Antal
91b5092c71
Merge branch 'project-pineapples' into T1079-MG-add-simple-query-to-benchmark_v2
2022-11-09 13:05:30 +01:00
János Benjamin Antal
c0f576c187
Merge pull request #645 from memgraph/MG-add-python-checks-pineapples
...
Add python checks
2022-11-09 13:05:15 +01:00
jbajic
a2735c8953
Add label add/remove in UpdateVertex req
2022-11-09 12:10:46 +01:00
jbajic
51fb4a6e7a
Remove empty line
2022-11-09 11:32:54 +01:00
jbajic
cba183898a
Update actions versions
2022-11-09 10:40:46 +01:00
jbajic
5f5fe7eb29
Add python checks
2022-11-09 10:39:29 +01:00
jeremy
2087877df2
Add more checks in test
2022-11-09 08:48:51 +01:00
Jeremy B
efa4378fb4
Merge branch 'project-pineapples' into T1079-MG-add-simple-query-to-benchmark_v2
2022-11-09 08:26:25 +01:00
jeremy
cad0e80d00
Update test
2022-11-08 17:42:31 +01:00
János Benjamin Antal
3c07a5dc04
Merge pull request #639 from memgraph/T1145-MG-handle-insertions-of-vertices-that-already-exist-in-a-better-way
...
Return an error for insertions of vertices that already exist
2022-11-08 17:11:22 +01:00
Jeremy B
e442963466
Merge branch 'project-pineapples' into T1079-MG-add-simple-query-to-benchmark_v2
2022-11-08 17:00:30 +01:00
János Benjamin Antal
32fe4d94d9
Merge branch 'project-pineapples' into T1145-MG-handle-insertions-of-vertices-that-already-exist-in-a-better-way
2022-11-08 16:35:38 +01:00
János Benjamin Antal
94b66a4e81
Merge pull request #638 from memgraph/T1148-MG-fix-expand-one-source-vertex
...
Fix setting the primary key of source vertex in ExpandOne
2022-11-08 16:35:30 +01:00
jeremy
b2f3fab693
Remove comment
2022-11-08 15:06:27 +01:00
jeremy
d7ce7cea13
Merge branch 'project-pineapples' into T1083-MG-limit-and-order-expand-one_v3
2022-11-08 15:02:56 +01:00
jeremy
61b9457718
Remove split-files logic from test code
2022-11-08 11:35:54 +01:00
János Benjamin Antal
159b30ba5f
Merge branch 'project-pineapples' into T1148-MG-fix-expand-one-source-vertex
2022-11-08 08:20:25 +01:00
gvolfing
b67e5b9a6c
Merge branch 'project-pineapples' into T1145-MG-handle-insertions-of-vertices-that-already-exist-in-a-better-way
2022-11-08 07:53:45 +01:00
gvolfing
79756ae6fb
Modify unit test
...
Instead of Creating an exception that is would be only used in this
file, just assert the type of the error the double vertex insertion
operation should yield.
2022-11-08 07:31:01 +01:00
jeremy
a54bcb9819
Remove un-necessary rm in workflow
2022-11-07 17:32:09 +01:00
jeremy
c16f948de9
Delete cache folder before running benchmark test
2022-11-07 13:08:35 +01:00
jeremy
2a7ed1ad82
Add single e2e benchmark test
2022-11-07 12:55:08 +01:00
jeremy
5201db46d2
Add assert for split_file
2022-11-07 12:15:57 +01:00
gvolfing
91550128a5
Conform unit test with the new error-handling
2022-11-07 11:46:24 +01:00
jeremy
d5966101ad
Merge branch 'T1079-MG-add-simple-query-to-benchmark_v2' of github.com:memgraph/memgraph into T1079-MG-add-simple-query-to-benchmark_v2
2022-11-07 10:55:48 +01:00
jbajic
88487e2513
Extract vertex creation from FillUpSourceVertexSecondaryLabels
2022-11-07 10:54:28 +01:00
jeremy
b10b1eb239
Correct shard configuration
2022-11-07 10:33:24 +01:00
jeremy
dca94f42bb
Update key type in shard configuration
2022-11-07 10:14:49 +01:00
gvolfing
39b40ecf00
Extend the Error enum instead of a separate type
...
The error representing that a vertex is already inserted into the
skip-list was represented by the struct AlreadyInseertedElement. Instead
of using that struct, extend the memgraph::storage::v3::Error scoped
enum and use that to represent the double-insertion error.
2022-11-07 10:00:34 +01:00
jeremy
baacc52a65
Add support for split file configuration
2022-11-07 09:54:14 +01:00
jeremy
5273d319e2
Add split file for access control
2022-11-07 09:53:29 +01:00
Jeremy B
23838b50ea
Merge branch 'project-pineapples' into T1079-MG-add-simple-query-to-benchmark_v2
2022-11-05 14:46:33 +01:00
Tyler Neely
d85fb94bc7
Merge pull request #634 from memgraph/T1122-MG-ShardManager-ThreadPool
...
Add shard manager thread pool
2022-11-04 16:41:53 +01:00
jbajic
4d2036249e
Fix e2e test
2022-11-04 16:37:35 +01:00
Jure Bajic
d23643d4ff
Merge branch 'project-pineapples' into T1148-MG-fix-expand-one-source-vertex
2022-11-04 16:19:55 +01:00
jbajic
e52ce1e363
Add expandone test
2022-11-04 16:18:18 +01:00
Tyler Neely
1abfe28806
Correctly use a moved transport interface while constructing CoordinatorWorker
2022-11-04 15:11:32 +00:00
jeremy
d17970f6d9
Update default value for --datasets
2022-11-04 16:04:45 +01:00
jeremy
9e72c7cb54
Add extra safe check to in case we call on dataset.py
2022-11-04 15:57:26 +01:00
Tyler Neely
528e30a9be
Avoid warning for not using captured this. Use std::move instead of forward where appropriate
2022-11-04 14:13:15 +00:00
Tyler Neely
bb7c7f7627
Make popped messages non-const to allow for RVO
2022-11-04 14:07:49 +00:00
jbajic
bab5e1386a
Address review comments
2022-11-04 15:05:55 +01:00
gvolfing
3d954e7abc
Restructure SchemaResult type and uts usage
...
Rename SchemaResult to ShardOperationResult move it into a separate
header and add a new type to the underlying variant that indicates that
the vertex, the user would like to insert into the skip-list already
exist.
2022-11-04 15:04:25 +01:00
Tyler Neely
fa5c9a2568
Make items popped from *worker::Queue const. Use std::move instead of std::forward in one place
2022-11-04 11:33:02 +00:00
Tyler Neely
c745f8c877
Fix build after breaking code suggestion
2022-11-04 11:32:17 +00:00
Tyler Neely
486231b1b9
Update src/machine_manager/machine_manager.hpp
...
Co-authored-by: Kostas Kyrimis <kostaskyrim@gmail.com >
2022-11-04 12:28:01 +01:00
Tyler Neely
43ad5855c4
Update src/machine_manager/machine_manager.hpp
...
Co-authored-by: Kostas Kyrimis <kostaskyrim@gmail.com >
2022-11-04 12:27:40 +01:00
Tyler Neely
24864ff7d2
Update src/coordinator/coordinator_worker.hpp
...
Co-authored-by: Kostas Kyrimis <kostaskyrim@gmail.com >
2022-11-04 12:17:57 +01:00
Tyler Neely
8598f6edf4
Fix a race condition that happens when logging from a detached thread in the cluster property test. Improve the ShardManager dtor and log statements
2022-11-04 11:14:39 +00:00
jeremy
e41073bc2c
Update script to need single argument for local dataset
2022-11-04 09:17:09 +01:00
jeremy
14e3e72565
Correct badly written range
2022-11-04 08:52:47 +01:00
gvolfing
1cee7ecb8a
Make ShardRsm aware of trying to write the same vertex into the skip-list
2022-11-04 08:12:37 +01:00
Jeremy B
690a389563
Merge branch 'project-pineapples' into T1079-MG-add-simple-query-to-benchmark_v2
2022-11-03 17:43:47 +01:00
Tyler Neely
9203616283
Merge branch 'project-pineapples' into T1122-MG-ShardManager-ThreadPool
2022-11-03 17:01:07 +01:00
Tyler Neely
d198819bf1
Merge pull request #637 from memgraph/tyler_remove_storage_v2_durability_test
...
Remove unit tests for storage v2
2022-11-03 17:00:46 +01:00
jbajic
3a8f01af79
Fix expand one source vertex pk setting
2022-11-03 16:29:28 +01:00
Tyler Neely
7e6ec8bb26
Capture this instead of all references in scope for call to std::visit to route CoordinatorWorker messages
2022-11-03 14:38:16 +00:00
Tyler Neely
6138d76690
Remove unit tests for storage v2
2022-11-03 14:21:17 +00:00
Tyler Neely
25fdb1a1f0
Make the high_density_shard_create_scan test run much faster
2022-11-03 13:48:11 +00:00
Tyler Neely
2de1d6c359
Fix UB due to integer overflow
2022-11-03 13:27:45 +00:00
Tyler Neely
0364311dd0
Log latency histograms in the high_density_shard_create_scan test
2022-11-03 12:44:47 +00:00
Tyler Neely
9235515dab
Reduce high_density_shard_create_scan shard+thread combinations. Log Raft write request demangled names
2022-11-03 12:38:12 +00:00
Tyler Neely
b83fb287ad
Apply feedback from clang-tidy
2022-11-03 11:00:07 +00:00
jeremy
70dc19dfdb
Mgbench: apply filtering on results from client
2022-11-03 11:03:21 +01:00
Tyler Neely
b685a21171
Merge branch 'project-pineapples' of github.com:memgraph/memgraph into T1122-MG-ShardManager-ThreadPool
2022-11-03 09:42:28 +00:00
Tyler Neely
4db83b8159
Add a few safety checks to the new concurrent Queue structures and the promise maps in the transport layer
2022-11-03 09:41:28 +00:00
Tyler Neely
dd8dd4f6c4
Restructure responsibilities for assigning request ids to the transport handles. Simplify promise tracking to avoid replier addresses, enabling eventual direct server return (DSR)
2022-11-03 09:31:06 +00:00
Tyler Neely
fa1ddfea12
Fix a bug where the MachineManager's destructor became incorrect after being moved
2022-11-02 17:45:27 +00:00
Tyler Neely
a815ec9617
Handle Coordinator work on a separate thread, unblocking the MachineManager to route additional messages to Shards
2022-11-02 17:15:52 +00:00
Tyler Neely
78528bd609
Avoid the ShutDown explicit acknowledgement due to jthread already blocking on this
2022-11-02 17:12:21 +00:00
Tyler Neely
6239f4fc3e
Simplify usage of PromiseKey in LocalTransportHandle to avoid replier address
2022-11-02 17:11:26 +00:00
Jeremy B
c5eb3ff2c0
Merge branch 'project-pineapples' into T1079-MG-add-simple-query-to-benchmark_v2
2022-11-02 17:01:08 +01:00
János Benjamin Antal
9f71ce0f78
Merge pull request #635 from memgraph/MG-expand-fixes
2022-11-02 15:55:49 +01:00
János Benjamin Antal
589dd36bf2
Make function parameter constant
2022-11-02 14:44:54 +01:00
János Benjamin Antal
57e7169203
Eliminate dangling reference from lambda
2022-11-02 14:22:01 +01:00
János Benjamin Antal
bb3b053375
Create edge in the correct direction
2022-11-02 14:22:01 +01:00
János Benjamin Antal
a96f489756
Count the number of requests per operator
2022-11-02 14:22:01 +01:00
jeremy
e909e7d2d8
Format
2022-11-02 14:18:04 +01:00
Jeremy B
2d91a7fd1e
Merge branch 'project-pineapples' into T1079-MG-add-simple-query-to-benchmark_v2
2022-11-02 14:14:24 +01:00
Jeremy B
1d18f1197f
Update tests/mgbench/dataset_creator.py
...
Co-authored-by: Jure Bajic <jure.bajic@memgraph.com >
2022-11-02 14:14:16 +01:00
Jeremy B
edeebf46ec
Update tests/mgbench/benchmark.py
...
Co-authored-by: Jure Bajic <jure.bajic@memgraph.com >
2022-11-02 14:13:58 +01:00
Jeremy B
1148fe9aad
Update tests/mgbench/datasets.py
...
Co-authored-by: Jure Bajic <jure.bajic@memgraph.com >
2022-11-02 14:13:40 +01:00
János Benjamin Antal
c92c795b1a
Merge pull request #632 from memgraph/MG-improve-parameters
2022-11-02 14:06:30 +01:00
János Benjamin Antal
0fee412f92
Merge branch 'project-pineapples' into MG-improve-parameters
2022-11-02 13:37:35 +01:00
Tyler Neely
7596e85358
When message conversion fails to happen, demangle the concrete type name and error log a useful message
2022-11-02 12:37:34 +00:00
Jeremy B
014836ca3c
Merge branch 'project-pineapples' into T1079-MG-add-simple-query-to-benchmark_v2
2022-11-02 12:51:12 +01:00
Tyler Neely
68654b5a19
Merge branch 'project-pineapples' of github.com:memgraph/memgraph into T1122-MG-ShardManager-ThreadPool
2022-11-02 10:55:18 +00:00
János Benjamin Antal
4d96bf5006
Merge pull request #628 from memgraph/T1138-MG-fix-edge-id-allocator
...
Fix passing of edge IdAllocator not by value but as pointer
2022-11-02 10:40:35 +01:00
Marko Budiselić
9bb70eb0b9
Merge branch 'project-pineapples' into T1138-MG-fix-edge-id-allocator
2022-11-01 19:38:10 +01:00
Marko Budiselic
0ff389ffc4
Add 3d gnuplot script
2022-11-01 19:33:12 +01:00
Jeremy B
7076788dd5
Merge branch 'project-pineapples' into T1079-MG-add-simple-query-to-benchmark_v2
2022-11-01 18:51:57 +01:00
Tyler Neely
ee4be9aa5b
Merge pull request #631 from memgraph/tyler_remove_shard_map_from_machine_manager
...
Remove redundant ShardMap copy from MachineManager to avoid race conditions
2022-11-01 18:33:37 +01:00
Jeremy B
96a2ad4b63
Merge branch 'project-pineapples' into T1079-MG-add-simple-query-to-benchmark_v2
2022-11-01 18:21:36 +01:00
Tyler Neely
84509fa477
Fix merge conflict with MachineManager constructor
2022-11-01 17:07:14 +00:00
Tyler Neely
19b5fe3caf
Merge branch 'project-pineapples' into tyler_remove_shard_map_from_machine_manager
2022-11-01 17:57:03 +01:00
Tyler Neely
74db669e23
Merge pull request #622 from memgraph/tyler_1k_shard_unit_test
...
Add test for 1k shards, 1k create vertices, and then a scan all
2022-11-01 17:56:42 +01:00
Tyler Neely
599802033f
Reformat TODO comment
2022-11-01 17:21:15 +01:00
Tyler Neely
6dd57426f8
Revert broken code suggestion
2022-11-01 15:51:37 +00:00
Tyler Neely
3c9f0c48e9
Merge branch 'project-pineapples' into tyler_1k_shard_unit_test
2022-11-01 16:31:29 +01:00
Tyler Neely
9a1258a708
Update tests/unit/1k_shards_1k_create_scanall.cpp
...
Co-authored-by: Kostas Kyrimis <kostaskyrim@gmail.com >
2022-11-01 16:31:14 +01:00
Tyler Neely
c55ca836a4
Update tests/unit/1k_shards_1k_create_scanall.cpp
...
Co-authored-by: Kostas Kyrimis <kostaskyrim@gmail.com >
2022-11-01 16:31:06 +01:00
Tyler Neely
5674ef4016
Update tests/unit/1k_shards_1k_create_scanall.cpp
...
Co-authored-by: Kostas Kyrimis <kostaskyrim@gmail.com >
2022-11-01 16:30:37 +01:00
Tyler Neely
77c2afc9e7
Add TODO about ID mapping improvements
2022-11-01 15:27:35 +00:00
Tyler Neely
27292dd921
Merge branch 'project-pineapples' into tyler_remove_shard_map_from_machine_manager
2022-11-01 16:20:54 +01:00
Jeremy B
e4f1fd8647
Merge branch 'project-pineapples' into T1079-MG-add-simple-query-to-benchmark_v2
2022-11-01 16:06:44 +01:00
János Benjamin Antal
4608af9d00
Merge branch 'project-pineapples' into MG-improve-parameters
2022-11-01 15:56:16 +01:00
János Benjamin Antal
50e72a7c28
Merge branch 'project-pineapples' into T1138-MG-fix-edge-id-allocator
2022-11-01 15:56:12 +01:00
János Benjamin Antal
17a104677d
Merge pull request #617 from memgraph/T1105-MG-profile-query-in-distributed
2022-11-01 15:55:52 +01:00
Tyler Neely
a6add80fc9
Use static RSM partitioning function for achieving a smooth Shard->ShardWorker distribution
2022-11-01 14:52:38 +00:00
Tyler Neely
5d3eaf6a55
Rename 1k_shards_1k_create_scanall test to high_density_shard_create_scan
2022-11-01 14:02:07 +00:00
Tyler Neely
a13f260236
Parameterize shard worker threads in the MachineConfig and simplify test output
2022-11-01 13:57:57 +00:00
jeremy
1f778ba5f3
Add possibility to give extra tests arg to MGBench
2022-11-01 14:14:55 +01:00
jeremy
787987168c
Make benchmark work with any customer datasets
2022-11-01 12:51:01 +01:00
János Benjamin Antal
7b4b1ba8ed
Speed up Parameters::AtTokenPosition
2022-11-01 11:51:35 +01:00
Tyler Neely
bb1e8aa164
Improve histogram output by adding a pretty table printing function
2022-11-01 10:46:25 +00:00
Tyler Neely
27a1311966
Merge branch 'tyler_1k_shard_unit_test' of github.com:memgraph/memgraph into T1122-MG-ShardManager-ThreadPool
2022-11-01 09:49:15 +00:00
János Benjamin Antal
30ff6487f2
Merge remote-tracking branch 'origin/project-pineapples' into T1105-MG-profile-query-in-distributed
2022-11-01 10:32:44 +01:00
Tyler Neely
119da2d7a7
Update CMakeLists.txt
2022-11-01 09:51:43 +01:00
Tyler Neely
fa972813d2
Update src/coordinator/shard_map.cpp
...
Co-authored-by: Jure Bajic <jure.bajic@memgraph.com >
2022-10-31 19:05:19 +01:00
Tyler Neely
951b058116
Complete migration from single-threaded ShardManager to multi-threaded ShardWorker processing
2022-10-31 18:04:30 +00:00
Tyler Neely
d0cad6e6ba
Temporarily duplicate shard management logic from ShardManger in ShardWorker
2022-10-31 17:25:08 +00:00
Tyler Neely
6138277972
Merge branch 'tyler_remove_shard_map_from_machine_manager' of github.com:memgraph/memgraph into T1122-MG-ShardManager-ThreadPool
2022-10-31 17:14:01 +00:00
Tyler Neely
2f77eb96ff
Remove redundant ShardMap copy from MachineManager to avoid race conditions
2022-10-31 16:49:46 +00:00
Tyler Neely
d7bc93c55f
Fill Cron next time promise from each worker thread
2022-10-31 16:17:34 +00:00
Tyler Neely
039d5f51d3
Merge branch 'project-pineapples' into T1122-MG-ShardManager-ThreadPool
2022-10-31 17:06:36 +01:00
Tyler Neely
cebe6f62fa
Implement skeleton worker threadpool for the ShardManager
2022-10-31 16:03:47 +00:00
jbajic
6834ce01fe
Fix edge id allocator
2022-10-31 16:26:56 +01:00
jeremy
4c5cd1f847
Add possibility to have MgBench working against local file
2022-10-31 16:10:04 +01:00
János Benjamin Antal
f9e2a66961
Add const qualifier to function parameters
2022-10-31 15:53:04 +01:00
János Benjamin Antal
d5700ab5ff
Use [[unlikely]] attribute
2022-10-31 15:53:04 +01:00
Tyler Neely
b0aaba6765
Merge branch 'project-pineapples' into tyler_1k_shard_unit_test
2022-10-31 15:47:38 +01:00
jeremy
e1f18f3733
Update location of Pokec datasets on aws
2022-10-31 15:19:34 +01:00
jeremy
c90b38faf0
Update aws address for datasets
2022-10-31 14:49:32 +01:00
jeremy
acbf3c764c
Remove arg from __init__
2022-10-31 13:35:41 +01:00
jeremy
37df41796f
git puMerge branch 'T1079-MG-add-simple-query-to-benchmark_v2' of github.com:memgraph/memgraph into T1079-MG-add-simple-query-to-benchmark_v2
2022-10-31 13:02:12 +01:00
jeremy
f04e1cda4b
Add function
2022-10-31 13:02:05 +01:00
Jeremy B
f28ba89584
Update tests/mgbench/dataset_creator.py
...
Co-authored-by: Jure Bajic <jure.bajic@memgraph.com >
2022-10-31 13:01:42 +01:00
jeremy
60485311c8
Merge branch 'T1079-MG-add-simple-query-to-benchmark_v2' of github.com:memgraph/memgraph into T1079-MG-add-simple-query-to-benchmark_v2
2022-10-31 12:57:46 +01:00
Jeremy B
36a1c43851
Merge branch 'project-pineapples' into T1079-MG-add-simple-query-to-benchmark_v2
2022-10-31 12:57:41 +01:00
Jeremy B
bae8c084b1
Update tests/mgbench/datasets.py
...
Co-authored-by: Jure Bajic <jure.bajic@memgraph.com >
2022-10-31 12:56:02 +01:00
Jeremy B
2898120eeb
Update tests/mgbench/datasets.py
...
Co-authored-by: Jure Bajic <jure.bajic@memgraph.com >
2022-10-31 12:55:42 +01:00
jeremy
d62a45752a
Remove unused variable
2022-10-31 12:55:38 +01:00
jeremy
c5ee6ffbc2
Update dataset_creator script
2022-10-31 12:41:28 +01:00
jeremy
5ef08f841a
Update Dataset creation script
2022-10-31 11:56:20 +01:00
Kostas Kyrimis
59c7d81ae8
[ 🍍 < T1086-MG] Test distributed operators e2e ( #607 )
...
* Fix Explain queries
* Add Vertex/Edge accessor support for properties
* Fix projections
* Fix expansions to fetch destination vertex properties
* Fix improper use of ShardMap on bolt and replaced it with the ShardRequestManager
* Add NameToId mappers on ShardRequestManager
* Add e2e tests for operators
* Fix OPTIONAL MATCH
2022-10-31 11:52:20 +02:00
jeremy
03c095e780
Update assert
2022-10-31 10:52:06 +01:00
Jeremy B
b542e49b3e
Merge branch 'project-pineapples' into T1079-MG-add-simple-query-to-benchmark_v2
2022-10-31 09:44:34 +01:00
Jeremy B
ddb30f49ea
Update datasets.py
2022-10-31 09:43:22 +01:00
János Benjamin Antal
d920d7c293
Merge branch 'project-pineapples' into T1105-MG-profile-query-in-distributed
2022-10-31 09:27:05 +01:00
jeremy
b2e9717ec3
Factor HandleRead(msgs::ExpandOneRequest..
2022-10-28 15:31:29 +02:00
jeremy
e0f6c951c1
Add possibilty to orderByElement on vector<VertexAccessor>
2022-10-28 15:31:15 +02:00
jeremy
7e35c71c58
Merge branch 'T1083-MG-limit-and-order-expand-one_v3' of github.com:memgraph/memgraph into T1083-MG-limit-and-order-expand-one_v3
2022-10-28 13:22:54 +02:00
Jeremy B
b6814b7a49
Update src/storage/v3/shard_rsm.cpp
...
Co-authored-by: Jure Bajic <jure.bajic@memgraph.com >
2022-10-28 13:22:49 +02:00
jeremy
903e29a081
Merge branch 'T1083-MG-limit-and-order-expand-one_v3' of github.com:memgraph/memgraph into T1083-MG-limit-and-order-expand-one_v3
2022-10-28 13:22:12 +02:00
Jeremy B
1c17692a26
Update src/storage/v3/shard_rsm.cpp
...
Co-authored-by: Jure Bajic <jure.bajic@memgraph.com >
2022-10-28 13:22:07 +02:00
jeremy
34fbaa0aee
Merge branch 'T1083-MG-limit-and-order-expand-one_v3' of github.com:memgraph/memgraph into T1083-MG-limit-and-order-expand-one_v3
2022-10-28 13:21:52 +02:00
Jeremy B
476e2670d5
Update src/storage/v3/request_helper.cpp
...
Co-authored-by: Jure Bajic <jure.bajic@memgraph.com >
2022-10-28 13:21:48 +02:00
jeremy
be7aa55686
Add std::move
2022-10-28 13:21:43 +02:00
jeremy
46388ad35c
Correct compilation
2022-10-28 13:10:00 +02:00
jeremy
0d5ee49e19
Correct test expectation
2022-10-28 12:55:56 +02:00
jeremy
74181114c2
Remove un-necessary variable
2022-10-28 12:55:47 +02:00
jeremy
009c1b4074
Replace include
2022-10-28 12:55:23 +02:00
jeremy
d0b8b27c29
Rename ordered->sorted
2022-10-28 12:52:37 +02:00
jeremy
79c2ae206f
Update FillEdges usage (for compilation)
2022-10-28 11:24:41 +02:00
Tyler Neely
6b0168cb3d
Add LocalTransport::ResponseLatencies
2022-10-28 08:51:12 +00:00
Tyler Neely
03cf264b76
Add test for 1k shards, 1k create vertices, and then a scan all
2022-10-28 08:29:27 +00:00
Tyler Neely
9448e23dc9
Check-in basic shard scheduler skeleton
2022-10-27 13:36:53 +00:00
Jeremy B
fa6129dc2b
Merge branch 'project-pineapples' into T1083-MG-limit-and-order-expand-one_v3
2022-10-26 15:59:15 +02:00
Tyler Neely
eafccaea84
Add a logarithmically bucketing histogram and record response latencies per message type ( #616 )
2022-10-26 15:57:11 +02:00
János Benjamin Antal
0c4f591b3c
Merge branch 'project-pineapples' into T1105-MG-profile-query-in-distributed
2022-10-26 14:48:27 +02:00
Jeremy B
aeed7c32f9
Merge branch 'project-pineapples' into T1083-MG-limit-and-order-expand-one_v3
2022-10-26 11:32:44 +02:00
János Benjamin Antal
534e365271
Suppress warning about exception escape for destructor
2022-10-26 11:22:27 +02:00
János Benjamin Antal
281ae158ec
Make ReadTSC noexcept
2022-10-26 11:21:27 +02:00
János Benjamin Antal
39c9c215b1
Suppress clang-tidy warnings for
2022-10-26 11:14:24 +02:00
János Benjamin Antal
f6e78ce6da
Fix TODOs in storage engine ( #614 )
...
Fixed various TODOs that were easy to fix to improve the code quality of the
newly implemented storage.
2022-10-26 10:40:35 +02:00
Jeremy B
8e7118efde
Merge branch 'project-pineapples' into T1083-MG-limit-and-order-expand-one_v3
2022-10-26 08:39:21 +02:00
János Benjamin Antal
3cf79f5bbf
Merge branch 'project-pineapples' into T1079-MG-add-simple-query-to-benchmark_v2
2022-10-25 21:24:20 +02:00
János Benjamin Antal
6a31c49432
Flatten nested conditional statements
2022-10-25 20:30:29 +02:00
János Benjamin Antal
fea92f4829
Merge remote-tracking branch 'origin/project-pineapples' into T1105-MG-profile-query-in-distributed
2022-10-25 20:28:54 +02:00
János Benjamin Antal
1703cd039d
Populate custom data of profile query with request wait times
2022-10-25 20:15:06 +02:00
gvolfing
ca2351124b
Make primary labels act as label indices ( #605 )
...
Because of the lexicographical sharding, the primary labels themselves are
acting as indexes. If a primary label is specified in a MATCH query we can
safely narrow the range of shards we have to scan through based on that label.
This PR introduces the necessary changes in order to achieve that.
2022-10-25 19:48:17 +02:00
János Benjamin Antal
5784c0d473
Return the custom data for profile queries
2022-10-25 15:26:42 +02:00
János Benjamin Antal
8ebc704819
Fix profile queries with ScanAll
2022-10-25 14:37:18 +02:00
János Benjamin Antal
5939fb2b0c
Start transaction properly
2022-10-25 14:35:26 +02:00
János Benjamin Antal
ee64684b0b
Add ScopedCustomProfile
2022-10-25 13:37:57 +02:00
János Benjamin Antal
1e4c02f8a5
Make profile query work
2022-10-25 13:37:27 +02:00
János Benjamin Antal
8353228ba7
Upgrade json lib to 3.11.2
2022-10-25 13:10:03 +02:00
jeremy
cdab8828e4
remove else
2022-10-25 12:30:14 +02:00
jeremy
c1d0fddaac
Remove unnecessary else
2022-10-25 11:31:23 +02:00
jeremy
18423ce34d
remove includes
2022-10-25 11:01:04 +02:00
jeremy
b4f68e7a60
remove includes
2022-10-25 10:56:16 +02:00
jeremy
e901c1fdb7
Refactor code
2022-10-25 10:45:33 +02:00
Jeremy B
016b3ee0d2
Merge branch 'project-pineapples' into T1083-MG-limit-and-order-expand-one_v3
2022-10-25 10:30:22 +02:00
János Benjamin Antal
332afadf21
Split file parsing ( #600 )
...
Add temporary support for split files. This is only temporary solution until we
get the shard splitting implemented.
2022-10-25 10:27:13 +02:00
Tyler Neely
acc655f4fd
Model-based testing of simulated full cluster ( #584 )
...
This PR adds support for generating randomized workloads that will be executed
against a simulated cluster, as well as against a correctness model. Initially
this just generates ScanAll and CreateVertex requests, and anything that it
creates, it also inserts into a `std::set`, and when we do a ScanAll, it asserts
that we get the same number of requests back. This will become much more
sophisticated over time, but it's already hitting pay-dirt.
2022-10-24 19:54:09 +02:00
jeremy
862af55266
Remove #NoCommit
2022-10-24 16:39:38 +02:00
jeremy
33c9ccee66
Adapt test
2022-10-24 16:38:28 +02:00
jeremy
8b9e7e2c65
Correct behavior of batch limit (was size_t)
2022-10-24 16:23:42 +02:00
jeremy
51e6802aa7
Safeguard in case ComputeExpression is called without opt
2022-10-24 15:44:57 +02:00
jeremy
386a0c5686
add comment
2022-10-24 15:44:37 +02:00
jeremy
994aab8774
Merge branch 'T1083-MG-limit-and-order-expand-one_v3' of github.com:memgraph/memgraph into T1083-MG-limit-and-order-expand-one_v3
2022-10-24 12:08:38 +02:00
jeremy
8112957a35
Merge branch 'project-pineapples' into T1083-MG-limit-and-order-expand-one_v3
2022-10-24 12:08:02 +02:00
jeremy
b82e8748ad
Attempt impl
2022-10-24 12:03:51 +02:00
Jeremy B
cb00b43ca7
Merge branch 'project-pineapples' into T1083-MG-limit-and-order-expand-one_v3
2022-10-21 18:17:34 +02:00
jeremy
55e0dbca80
Add limit to ExpandOne
...
Add missing pragma
Add test
Merge conflicts
2022-10-21 16:32:49 +02:00
Tyler Neely
12e7a261aa
operator<< implementations for a few foundational types (#604 )
2022-10-21 15:25:40 +02:00
Marko Budiselić
1c3bb969e9
Decouple interactive planning manual test ( #585 )
2022-10-21 13:34:13 +02:00
Jure Bajic
e5437080c5
Handle OrderBy in ScanVertices request ( #594 )
...
- Refactor shard_rsm and move function into expr.hpp/expr.cpp and request_helper.hpp/request_helper.cpp
2022-10-21 12:33:40 +02:00
Tyler Neely
17090dd8ac
Load SPDLOG_LEVEL environment variable in unit tests binaries ( #606 )
...
Co-authored-by: János Benjamin Antal <antaljanosbenjamin@users.noreply.github.com >
2022-10-20 18:27:52 +02:00
gvolfing
281cebd386
Add filtering capabilities to ExpandOne request ( #581 )
2022-10-20 17:51:44 +02:00
János Benjamin Antal
f89a2bbf42
Make ExpandOne work in the query engine ( #589 )
2022-10-20 11:35:00 +02:00
gvolfing
85b8ce9101
Implement filtering capabilities for ScanAll ( #578 )
...
ScanVerticesrequest was not able to utilize filtering capabilities
before. With these modification it is now able to filter the scanned
vertices based on the filter_expressions field in the
ScanVerticesRequest message type.
2022-10-19 16:09:00 +02:00
Jure Bajic
6bb40a7f49
Create ExpandOne request ( #580 )
...
Refactor CreateEdge into CreateExpand
2022-10-19 13:55:46 +02:00
Jeremy B
1707ee648e
Merge branch 'project-pineapples' into T1079-MG-add-simple-query-to-benchmark_v2
2022-10-19 08:47:13 +02:00
gvolfing
07f34838bd
Add e2e test to check ScanAll on new architecture ( #603 )
...
Add testing capabilities similar to what existed before on the older
architecture. With this test specifically, test if we can create
vertices and return them with ScanAll. There is a hard-coded 3s wait in
the test which is needed because the MachineManager need this time to
initialize itself.
2022-10-18 21:38:56 +02:00
Jeremy B
b6f8b5e130
Merge branch 'project-pineapples' into T1079-MG-add-simple-query-to-benchmark_v2
2022-10-18 15:49:19 +02:00
jeremy
58243f4a26
Rename User->File
...
Use parser for argument i.o. simple variable in script
2022-10-18 15:47:13 +02:00
gvolfing
d06132cb33
Make ShardRequestManager work with futures ( #588 )
...
The communication between the ShardRequestManager and the RsmClient
used to be direct. In this PR this changes into a future-based
communication type. The RsmClient stores state about the currently
processed future (either read or write request) and exposes blocking
and non-blocking functionality to obtain the filled future. The
ShardRequestManager -for now- will send of the set of requests present
in the ExecutionState and block on each of them until the requests are
completed or the set of paginated responses(caused by, for example the
batch-limit in ScanAll) are ready for the next round.
2022-10-18 09:53:37 +02:00
Jeremy B
f063c1b1ad
Merge branch 'project-pineapples' into T1079-MG-add-simple-query-to-benchmark_v2
2022-10-17 11:41:55 +02:00
Marko Budiselić
5347c06d76
Add shutdown of LocalSystem during the shutdown process ( #592 )
2022-10-14 11:59:50 +02:00
Tyler Neely
4634ac484a
Optimize simulator RNG usage ( #590 )
...
This causes instructions for `basic_request.cpp` to drop from 281 million to 28 million
2022-10-12 19:19:06 +03:00
jeremy
a5dc818e19
Add new dataset for mgbench
2022-10-12 16:35:47 +02:00
Jeremy B
4cb3b064c4
Add filter to scan all ( #575 )
...
Add several versions of ScanAll with filters.
Add helper function to transform an expression into string that can be parsed again once on the storage.
2022-10-12 11:46:59 +02:00
Jure Bajic
23171e76b6
Integrate bolt server ( #572 )
...
* Use query-v2 in the main executable
* Set up machine manager in memgraph
* Add `ShardRequestManager` to `Interpreter`
* Make vertex creation work
* Make scan all work
* Add edge type map in shard request manager
* Send schema over request
* Empty out DbAccessor
* Store shard mapping at creation
* Remove failing CI steps
Cooltura is the best place in Zagreb!
Co-authored-by: János Benjamin Antal <benjamin.antal@memgraph.io >
2022-10-11 16:31:46 +02:00
Jeremy B
6fd64d31f2
Update usage of Shard ( #574 )
...
Updating tests to use new constructor of Shard
Commenting test shard_request_manager
2022-10-05 11:56:36 +02:00
gvolfing
87111b2f89
Implement missing message handlers ( #563 )
...
Implement the missing message handlers with basic functionality. The
implementation does not include any capabilities to filter based on
expressions.
2022-10-03 15:31:06 +02:00
Tyler Neely
b5c7078c7d
Stitch request manager with shard ( #570 )
...
Fix various bugs
2022-09-23 20:07:41 +02:00
Kostas Kyrimis
925835b080
Implement query engine client ( #531 )
...
- Add shard request manager
2022-09-22 15:05:43 +02:00
Tyler Neely
ce788f5f65
Machine manager and shard stitch ( #569 )
2022-09-22 13:55:16 +02:00
János Benjamin Antal
b8186bea2e
Lexicographically ordered storage ( #454 )
2022-09-21 18:58:31 +02:00
János Benjamin Antal
3c4856dcb7
Merge remote-tracking branch 'origin/project-pineapples' into E118-MG-lexicographically-ordered-storage
2022-09-21 18:50:00 +02:00
Marko Budiselić
b4d6dc0930
Add proper transaction handling ( #550 )
2022-09-21 18:25:51 +02:00
Jure Bajic
817161a915
Implement expression evaluator in storage v3 ( #534 )
...
- Enable `mg-expr` in mg-storage-v3
- Adapt id_mapper
- Change conversion function from PropertyValue to TypedValue
- Remove memgraph functions
- Enable expression tests on for storage
2022-09-21 17:26:55 +02:00
Tyler Neely
58eb2caf0f
Add machine manager prototype ( #533 )
2022-09-21 16:57:25 +02:00
gvolfing
ecda71168c
Implement message based actions ( #538 )
...
Create shard-side handlers for basic messages
Implement the handlers for CreateVertices, CreateEdges and ScanAll. Use
or modify the defined messages to interact with individual Shards and
test their behavior. Shard is currently being owned by ShardRsm
instances. The two top level dispatching functions Read() and Apply()
are responsible for read- and write operations respectively. Currently
there are a handful of messages that are defined but not utilized, these
will be used in the near future, as well as a couple of handler
functions with empty implementations.
2022-09-20 11:15:19 +02:00
János Benjamin Antal
8e1f83acc9
Reference vertices by id in edges ( #532 )
2022-09-14 13:11:14 +02:00
jbajic
f910cb770c
Merge branch 'project-pineapples' into E118-MG-lexicographically-ordered-storage
2022-09-09 12:39:28 +02:00
Kostas Kyrimis
38d0b89b04
Implement expression evaluator library ( #486 )
2022-09-07 18:15:32 +03:00
Jure Bajic
a2a6a3855b
Remove primary label from vertex ( #529 )
...
- Remove the primary label from vertex
- Pass vertex_validator instead of schema validator
- Fix vertex ctors
2022-09-07 13:36:10 +02:00
Jure Bajic
e9f0360fb3
Enable indices for storage v3 ( #528 )
...
- Enable indices in storage v3
- Add new test cases
- Change `CreateVertexAndValidate` to call `SetProperty` and `AddLabel`
2022-09-06 22:48:25 +02:00
János Benjamin Antal
fe4955447e
Merge branch 'project-pineapples' into E118-MG-lexicographically-ordered-storage
2022-09-05 14:59:01 +02:00
Tyler Neely
1631c20df2
In memory shard map ( #505 )
2022-09-05 15:50:54 +03:00
János Benjamin Antal
947baedbe6
Merge remote-tracking branch 'origin/project-pineapples' into E118-MG-lexicographically-ordered-storage
2022-09-02 11:41:03 +02:00
Kostas Kyrimis
c6447eb48b
Add shard requests responses ( #526 )
2022-09-01 18:54:47 +03:00
Jure Bajic
7e84744d07
Split storage and shards ( #519 )
...
- Rename storage to shard
- Add primary label and range for shard
- Remove id_mapper functionality from shard
- Adapt tests
2022-09-01 09:10:40 +02:00
Tyler Neely
c0d03888f4
Implement basic raft version ( #498 )
2022-08-30 15:07:34 +02:00
János Benjamin Antal
efb3c8d03d
Remove multi-threaded related logic and variables ( #460 )
...
* Remove logic that was necessary for optimal multi-threaded performance, such
as accumulating deleted object in local containers and appending them to a
global one, handling overlapping locking.
* Remove background GC thread.
* Remove mutexes, locks and atomics throughout storage.
2022-08-30 13:41:53 +02:00
Jure Bajic
95dbc022c0
Integrate schema and keystore ( #497 )
...
- Integrate schema and keystore on vertex creation
- Add GC test for storage v3
- Add tests for accessors
- Fix all tests related to this except for query v2
- Fix labels not returning primary label
2022-08-29 14:38:25 +02:00
Tyler Neely
a40403e3ce
Add local transport ( #512 )
...
* Create LocalTransport Io provider for sending messages to components on the same machine
* Move src/io/simulation/message_conversion.hpp to src/io/message_conversion.hpp for use in other Io providers
2022-08-29 13:49:51 +02:00
Tyler Neely
14c9e68456
Transport prototype ( #466 )
2022-08-12 08:24:32 +02:00
jbajic
68b26275a3
Merge branch 'project-pineapples' into E118-MG-lexicographically-ordered-storage
2022-08-08 11:34:46 +02:00
jbajic
5012824e05
Address review comments
2022-08-04 11:45:16 +02:00
Jure Bajic
a12a1ea358
Move schema to storage v3 and query v2
...
* Move schema to storage v3
* Remove schema from v2
* Move schema to query v2
* Remove schema from query v1
* Make glue v2
* Move schema related tests to newer versions of query and storage
* Fix typo in CMake
* Fix interpreter test
* Fix clang tidy errors
* Change temp dir name
2022-08-04 09:50:02 +02:00
János Benjamin Antal
2891041468
Make storage use KeyStore ( #455 )
2022-08-03 18:10:58 +02:00
János Benjamin Antal
cc5ee6a496
Merge remote-tracking branch 'origin/project-pineapples' into E118-MG-lexicographically-ordered-storage
2022-08-02 08:19:43 +02:00
jbajic
f57f30c8cf
Merge branch 'project-pineapples' into E112-MG-implement-partial-schema
2022-08-01 10:46:11 +02:00
Jure Bajic
462daf3a2b
Enforce schema on vertex creation
...
- Separating schema definition from schema validation
- Updating vertex_accessor and db_accessors with necessary methods
- Adding a primary label to Vertex
- Adding schema tests
- Updating existing tests for storage v3, and deprecating old:
- interpreter => interpreter_v2
- query_plan_accumulate_aggregate => storage_v3_query_plan_accumulate_aggregate
- query_plan_create_set_remove_delete => storage_v3_query_plan_create_set_remove_delete
- query_plan_bag_semantics => storage_v3_query_plan_bag_semantics
- query_plan_edge_cases => storage_v3_query_plan_edge_cases
- query_plan_v2_create_set_remove_delete => storage_v3_query_plan_v2_create_set_remove_delete
- query_plan_match_filter_return => storage_v3_query_plan_match_filter_return
2022-07-29 13:38:17 +02:00
Marko Budiselic
2009fefc8a
Merge branch 'master' into project-pineapples
2022-07-28 15:36:51 +02:00
Marko Budiselić
eb3f96d1f6
Bring changes from master to project-pineapples ( #477 )
...
* Fix aggregation functions on `null` and group-by inputs (#448 )
* Upgrade Antrl to 4.10.1 and remove antlr_lock (#441 )
* Update clang-tidy job (#476 )
* Add parser stress test (#463 )
NOTE: Doing this to have buildable comments on the project-pineapples branch
Co-authored-by: gvolfing <107616712+gvolfing@users.noreply.github.com >
Co-authored-by: Jure Bajic <jure.bajic@memgraph.com >
2022-07-28 15:36:17 +02:00
Marko Budiselić
80e0e439b7
Add parser stress test ( #463 )
2022-07-26 20:54:56 +02:00
Jure Bajic
351258ace8
Update clang-tidy job ( #476 )
...
Update clang tidy job to only check the diff against the base branch
2022-07-26 16:53:56 +02:00
Marko Budiselić
74d3663821
Upgrade Antrl to 4.10.1 and remove antlr_lock ( #441 )
2022-07-26 08:31:38 +02:00
jbajic
264b233053
Merge branch 'project-pineapples' into E112-MG-implement-partial-schema
2022-07-22 11:48:45 +02:00
Jure Bajic
2ceaf59767
Create query engine v2 ( #444 )
...
Create version v2 of the query engine.
Adjust CMake and lisp files
Connect query engine v2 with storage engine v3
2022-07-19 12:28:19 +02:00
gvolfing
eb0b3141d5
Fix aggregation functions on null and group-by inputs ( #448 )
...
The `sum()` and `count()` functions were giving results different from the openCypher specification on null `input.` The aggregation functions also had a problem when they were used in a group-by context and were giving results that were not compliant with the openCypher specification.
2022-07-19 12:16:32 +02:00
János Benjamin Antal
c0bee760bf
git
2022-07-18 08:21:04 +02:00
Marko Budiselić
ff2f8031a9
Extend the PR template with the git message guide ( #451 )
2022-07-15 14:08:10 +02:00
Marko Budiselić
094d4f282d
Improve error-prone OS setup ( #428 )
2022-07-13 17:48:01 +02:00
Jure Bajic
3dd2657320
Create mgp python package ( #433 )
2022-07-12 10:54:23 +02:00
gvolfing
6fe474282a
Modify logaical operators to conform openCyper regarding checking against NULL in CASE expressions ( #432 )
...
* Make `IfOperator` return the `else_expression_` in case of `NULL`
* Add gql_behave tests
* Add gql_behave test to specifically check for the case when the test expression itself is null
2022-07-11 15:00:29 +02:00
gvolfing
7fc0fb6520
Implement ToString function for temporal datatypes ( #429 )
...
* Modify `toString` to be able to handle `Date`, `LocalTime`, `LocalDateTime` and `Duration`
* Add unit tests
* Make `operator<<` use the `ToString()` implementations
* Add tests to verify the correctness of negative durations
* Add more tests to look for cases when the individual duration entities overflow.
2022-07-11 13:44:27 +02:00
Jure Bajic
3f4f66b57f
Create schema DDL expressions
...
* Add initial schema implementation
* Add index to schema
* List schemas and enable multiple properties
* Implement SchemaTypes
* Apply suggestions from code review
Co-authored-by: Jeremy B <97525434+42jeremy@users.noreply.github.com >
Co-authored-by: János Benjamin Antal <antaljanosbenjamin@users.noreply.github.com >
* Address review comments
* Remove Map and List
* Add schema operations in storage
* Add create and show schema queries
* Add privileges for schema
* Add missing keywords into lexer
* Add drop schema query
* Add schema visitors
* Update metadata
* Add PrepareSchemaQuery function
* Implement show schemas
* Add show schema query
* Fix schema visitor
* Add common schema type
* Fix grammar
* Temporary create ddl logic
* Fix naming for schemaproperty type to schema type
* Rename schemaproperty to schemapropertytype
* Enable Create schema ddl
* Override visitPropertyType
* Add initial schema implementation
* Add initial schema implementation
* Add index to schema
* List schemas and enable multiple properties
* Implement SchemaTypes
* Apply suggestions from code review
Co-authored-by: Jeremy B <97525434+42jeremy@users.noreply.github.com >
Co-authored-by: János Benjamin Antal <antaljanosbenjamin@users.noreply.github.com >
* Address review comments
* Remove Map and List
* Apply suggestions from code review
Co-authored-by: Kostas Kyrimis <kostaskyrim@gmail.com >
Co-authored-by: Jeremy B <97525434+42jeremy@users.noreply.github.com >
Co-authored-by: János Benjamin Antal <antaljanosbenjamin@users.noreply.github.com >
Co-authored-by: Kostas Kyrimis <kostaskyrim@gmail.com >
* Add verification on creation and deletion
* Rename DeleteSchema to DropSchema
* Remove list and map from lexer
* Fix grammar with schemaTypeMap
* Add privilege and cypher visitor tests
* Catch repeating type name in schema definition
* Fix conflicting keywords
* Add notifications
* Drop float support
* Finish interpreter tests
* Fix tests
* Fix clang tidy errors
* Fix GetSchema
* Replace for with transfrom
* Add cloning og schema_property_map
* Address review comments
* Rename SchemaPropertyType to SchemaType
* Remove inline
* Assert of schema properties
Co-authored-by: Jeremy B <97525434+42jeremy@users.noreply.github.com >
Co-authored-by: János Benjamin Antal <antaljanosbenjamin@users.noreply.github.com >
Co-authored-by: Kostas Kyrimis <kostaskyrim@gmail.com >
2022-07-11 09:20:15 +02:00
Jeremy B
063e297e1e
Avoid usage of time.sleep ( #434 )
...
e2e python: added tooling function around `time.sleep()` that stops as soon as condition is fulfilled and will raise assert if timeout is reached
2022-07-08 10:47:18 +02:00
Jure Bajic
2998f92595
Add initial schema implementation
...
* Add initial schema implementation
* Add index to schema
* List schemas and enable multiple properties
* Implement SchemaTypes
* Apply suggestions from code review
Co-authored-by: Jeremy B <97525434+42jeremy@users.noreply.github.com >
Co-authored-by: János Benjamin Antal <antaljanosbenjamin@users.noreply.github.com >
* Address review comments
* Remove Map and List
* Apply suggestions from code review
Co-authored-by: Kostas Kyrimis <kostaskyrim@gmail.com >
Co-authored-by: Jeremy B <97525434+42jeremy@users.noreply.github.com >
Co-authored-by: János Benjamin Antal <antaljanosbenjamin@users.noreply.github.com >
Co-authored-by: Kostas Kyrimis <kostaskyrim@gmail.com >
2022-07-08 10:33:43 +02:00
Ante Javor
86b1688192
Rewrite Python API comments and snippets ( #420 )
...
* Update comments
2022-07-07 15:05:56 +02:00
Jeremy B
f629de7e60
Save replication settings ( #415 )
...
* Storage takes care of the saving of setting when a new replica is added
* Restore replicas at startup
* Modify interactive_mg_runner + memgraph to support that data-directory can be configured in CONTEXT
* Extend e2e test
* Correct typo
* Add flag to config to specify when replication should be stored (true by default when starting Memgraph)
* Remove un-necessary "--" in yaml file
* Make sure Memgraph stops if a replica can't be restored.
* Add UT covering the parsing of ReplicaStatus to/from json
* Add assert in e2e script to check that a port is free before using it
* Add test covering crash on Jepsen
* Make sure applciaiton crashes if it starts on corrupted replications' info
Starting with a non-reponsive replica is allowed.
* Add temporary startup flag: this is needed so jepsen do not automatically restore replica on startup of main. This will be removed in T0835
2022-07-07 13:30:28 +02:00
Jeremy B
b737e53456
Remove sync with timeout ( #423 )
...
* Remove timout when registering a sync replica
* Simplify jepsen configuration file
* Remove timeout from jepsen configuration
* Add unit test
* Remove TimeoutDispatcher
2022-07-05 09:40:50 +02:00
János Benjamin Antal
1bdc32ba5d
Copy storage v2 to create storage v3 ( #416 )
...
* Copy storage v2 to v3
* Integrate v3 to cmake
* Fix clang-tidy warnings
* Add dummy unit test for storage-v3 to trigger build for code analysis builds
2022-07-05 08:20:59 +02:00
János Benjamin Antal
10ca68bb2a
Remove CODEOWNERS ( #427 )
...
Co-authored-by: Marko Budiselić <marko.budiselic@memgraph.com >
2022-07-04 16:42:36 +02:00
Jure Bajic
bfbd8538d4
Update docker release process ( #421 )
...
* Fix release directory
* Update release process
* Fix debian arm path
2022-07-04 16:10:33 +02:00
Jeremy B
3e0e17d469
Adding assert in e2e script to check that a port is free before using it ( #425 )
...
* Adding assert in e2e script to check that a port is free before using it
* Adding extra logging
2022-07-04 10:14:02 +02:00
Jeremy B
b57f91fcfc
Correct concurrency group ( #426 )
...
* Correct concurrency group
2022-07-01 16:53:41 +02:00
Jeremy B
066a96c0ae
Adding concurrency to cancel current workflow if one commits on the same branch. ( #424 )
...
* Adding concurrency to cancel current workflow if one commits on the same branch.
2022-07-01 15:47:50 +02:00
Jeremy B
1ae6b71c5f
Registering a replica with timeout 0 should not be allowed ( #414 )
2022-06-29 11:14:23 +03:00
János Benjamin Antal
21870a0e7e
Merge branch 'master' into project-pineapples
2022-06-23 14:49:14 +02:00
Jure Bajic
cbe15e7f44
Support Ubuntu 22.04 ( #411 )
...
* Fix toolchain url
* Add 22.04 os script
* Update centos-9 stream
* Update zlib
* Upgrade dotnet version
* Add libipt
* Update toolchain extension
* Add release container
* Remove CentOS 8
* Enable arm packaging
* Add centos 9 container
* Ignore missing python virtualenv
* Add virtualenvwrapper
* Rearrange order
* Install virtualenv without user
* Run virtualenv via python
* Add logrotate dependency
* Bump up checkout action version
2022-06-23 14:02:21 +02:00
Jeremy B
65a7ba01da
Add information on show replicas to express how up-to-date a replica is ( #412 )
...
* Add test
* Add implementation and adapted test
* Update workloads.yaml to have a timeout > 0
* Update tests (failing due to merging of "add replica state")
2022-06-23 10:22:57 +02:00
Kostas Kyrimis
7a2bbd4bb3
Remove ref from std::string_view ( #215 )
2022-06-21 17:18:43 +03:00
Jeremy B
589e0e098b
Forbid two replicas to point to the same ip port ( #406 )
2022-06-20 17:10:20 +03:00
Jeremy B
41d4185156
Add limit batches option to start stream query ( #392 )
2022-06-20 15:09:45 +03:00
Marko Budiselić
599c0a641f
Add replica state to SHOW REPLICAS ( #379 )
2022-06-20 13:28:42 +03:00
Tyler Neely
1fb49c4865
Add an uncatchable kill method to the python MemgraphInstanceRunner for testing abrupt failures ( #405 )
2022-06-15 12:16:11 +03:00
János Benjamin Antal
df1485aeec
Run clang-tidy also on our header files ( #402 )
2022-06-10 11:26:24 +02:00
Jure Bajic
b2e1056389
Fix websocket connection ( #403 )
...
* Fix websocket connection with other clients
2022-06-09 22:19:43 +02:00
Jeremy B
e4c9411e63
Correcting USE_JEMALLOC flag ( #401 )
...
* Correcting USE_JEMALLOC flag
* Removing references to jemalloc local copy in /libs
2022-06-09 18:55:28 +02:00
Jeremy B
a0bc1371dd
Adding "raw message" column to the result returned by CHECK STREAM query ( #394 )
...
* Adding "raw message" column to the result return by CHECK STREAM query
* Update way results of CHECK STREAM are built
* Adapting CHECK STREAM integration tests (Pulsar/Kafka) to run with new result structure
* Adding new tests covering the check stream functionality
* Uppercase constants in stream tests
* Reformat f-strings
2022-06-08 23:17:44 +02:00
Marko Budiselić
21ad5d4328
Fix SHOW REPLICATION ROLE and SHOW REPLICAS ( #376 )
2022-05-20 20:17:59 -07:00
Marko Budiselić
8e3ab1ad0f
Add frequent replica ping ( #380 )
2022-05-20 19:29:17 -07:00
Marko Budiselić
cccf32e79d
Add default commented values for Bolt SSL flags ( #398 )
2022-05-18 08:34:07 +02:00
Jure Bajic
22bd60c613
Fix shutdown call ( #395 )
...
* Fix shutdown not called
* Add ssl server tests
2022-05-18 07:50:06 +02:00
János Benjamin Antal
8059a3e653
Improve magic functions docs ( #391 )
...
* Improve documentation of magic functions
* Improve wording for decorators
2022-05-17 15:33:28 +02:00
Antonio Andelic
a7f4c98bea
Fix module symbol loading ( #335 )
...
* Use DEEPBIND
* Add dependency on libstdc++
Co-authored-by: Antonio Andelic <antonio.andelic@memgraph.io >
Co-authored-by: Jure Bajic <jure.bajic@memgraph.com >
2022-05-13 11:43:10 +02:00
Jure Bajic
483f4d04bd
Update precommit hooks ( #393 )
...
* Add pre-commit
* Add clang pre-commit
* Install pre-commit in init
2022-05-11 21:07:04 +02:00
János Benjamin Antal
3e7aef432f
Improve docker-compose setup for running streams e2e tests locally ( #388 )
...
* Separate pulsar and kafka docker-compose files
* Add docker-compose for redpanda
* Add small docs how to use docker-compose files
2022-05-10 13:31:45 +02:00
Jeremy B
10ea9c773e
Making mgp_error enum class when compiling c++. Remains enum when com… ( #389 )
...
* Making mgp_error enum class when compiling c++. Remains enum when compiling c.
2022-05-05 17:48:17 +02:00
Jeremy B
b782271be8
Fix shared module loading
...
* Moving function add_query_module from CMakeLists from tests/e2e/magic_functions to tests/e2e
* Adding failing test copying behavior when loading c module (.so) into memgraph.
* Fixing issue where NO_ERROR status returned MgpTransAddFixedResult was converted to false
* Removing unnecessary transformation
* removing incorrect parameterization of test
* re-adding parametrized transformation
2022-04-28 20:28:44 +02:00
Jure Bajic
a8ffcfa046
Update license year
...
* Update license year
Co-authored-by: János Benjamin Antal <antaljanosbenjamin@users.noreply.github.com >
Co-authored-by: János Benjamin Antal <antaljanosbenjamin@users.noreply.github.com >
2022-04-27 13:31:37 +02:00
Jure Bajic
7b78665cd8
Implement Bolt over WebSocket with asio
...
* Replace server implementation with asio
* Add support for bolt over WebSocket
2022-04-27 10:13:16 +02:00
Josip Matak
4abaf27765
Memgraph magic functions ( #345 )
...
* Extend mgp_module with include adding functions
* Add return type to the function API
* Change Cypher grammar
* Add Python support for functions
* Implement error handling
* E2e tests for functions
* Write cpp e2e functions
* Create mg.functions() procedure
* Implement case insensitivity for user-defined Magic Functions.
2022-04-21 15:45:31 +02:00
Kostas Kyrimis
ea2806bd57
Implement foreach clause ( #351 )
2022-04-11 13:55:34 +03:00
Siniša Šušnjar
c8dbaf5979
Small io network socket fixes ( #360 )
...
* Modernize AddrInfo
* Modernize Socket
2022-04-08 14:38:13 +02:00
Jure Bajic
17049ada09
Resolve python dependency issues ( #372 )
2022-04-07 17:56:18 +02:00
Jure Bajic
1b619f51b2
Add docker release action ( #356 )
...
* Add docker release action
* Add debian-11 arm script
* Remove test prefix
* Update package_docker script
* Update release script
* Unify architecture extension
2022-04-07 15:23:18 +02:00
János Benjamin Antal
537855a0b2
Fix usages of constexpr ( #367 )
...
* Fix usages of constexpr
2022-03-31 13:52:43 +02:00
Jure Bajic
5822b44b15
Fix CentOS 7 release process ( #369 )
2022-03-31 07:20:53 +02:00
g-despot
bf01c58ed9
Update README.md
2022-03-22 04:50:01 +01:00
g-despot
89a5566f3f
Update README.md
2022-03-22 04:49:03 +01:00
g-despot
29452f8774
Update README.md
2022-03-21 16:49:02 +01:00
jbajic
60ad05acff
Address review comments
2022-03-14 15:47:41 +01:00
jbajic
4f593c7fca
Adapt precommit to run through all files
2022-03-14 15:47:41 +01:00
jbajic
770ea1189a
Fix SSL errors
2022-03-14 15:47:41 +01:00
jbajic
695bb343f1
Resolve clang-tidy error
2022-03-14 15:47:41 +01:00
jbajic
12b4ec1589
Add memgraph namespace
2022-03-14 15:47:41 +01:00
Antonio Andelic
b33d2c3940
use boost ssl
2022-03-14 15:47:41 +01:00
Marko Budiselić
477acad1f6
Update CODEOWNERS file ( #362 )
2022-02-25 13:42:27 +01:00
János Benjamin Antal
ddca2b40f5
Remove unimplemented function declaration ( #357 )
2022-02-24 11:49:22 +01:00